Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LoadBalancer.hpp #92

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

vikaskurapati
Copy link
Collaborator

modified the get_command_output function to ignore the initial lines of a HPC cluster's output until the job id is given

modified the get_command_output function to ignore the initial lines of a HPC cluster's output until the job id is given
@linusseelinger
Copy link
Member

Looks good @vikaskurapati :)

One more thing: iirc, sbatch may return JOB_ID[;CLUSTER_NAME] . I think the regex doesn't capture that case yet?

@monabraeunig , once this is ready, could you give it a try on Helix? The PR changes how the SLURM backend gets the SLURM job ID from the sbatch command (should be more robust in case sbatch gives extra output in addition to job ID/cluster name). Should work smoothly, but worth a double check.

@vikaskurapati
Copy link
Collaborator Author

One more thing: iirc, sbatch may return JOB_ID[;CLUSTER_NAME] . I think the regex doesn't capture that case yet?

This is done. Please take a look now.

@linusseelinger
Copy link
Member

Thanks, I think that does the trick! Will ask @monabraeunig to test on another cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants