ESLint expects config modules to start eslint-config-
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-horton-ho-sas
requested review from
farrukhishaq,
parvinba and
kiran-varma-home-office
kiran-varma-home-office
approved these changes
Aug 6, 2024
parvinba
approved these changes
Aug 6, 2024
github-actions
bot
force-pushed
the
switch-to-eslint-config-asl
branch
from
a83e63b to
f7e54fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint only accepts modules prefixed with
eslint-configwhen loading config: Creating a shareable config. This needs to be renamed so that we can reference it by module name. The previous workaround of referencing the reletive path of index.js doesn't work inaspel-workspace(and using the workspaces reletive path would be incorrect for linting in drone).This change allows us to use
extends: ['@ukhomeoffice/asl']which works in both scenarios.