Maz scale microdata devprojects #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fscottfoti
reviewed
May 2, 2018
baus/models.py
Outdated
| @@ -345,7 +345,7 @@ def scheduled_development_events(buildings, development_projects, | |||
| new_buildings.building_type.fillna("OF").map(building_sqft_per_job) | |||
| new_buildings["job_spaces"] = new_buildings.job_spaces.\ | |||
| fillna(0).astype('int') | |||
| new_buildings["geom_id"] = parcel_id_to_geom_id(new_buildings.parcel_id) | |||
| #new_buildings["geom_id"] = parcel_id_to_geom_id(new_buildings.parcel_id) | |||
There was a problem hiding this comment.
can remove this line now?
baus/datasources.py
Outdated
| df = pd.read_csv(os.path.join(misc.data_dir(), "development_projects.csv")) | ||
| # find nearest parcel centroid to dev project x, y and assign parcel_id | ||
| df = df[(df.x.notnull()) & (df.y.notnull())] | ||
| df['parcel_id'] = nearest_neighbor(parcels.to_frame(['x','y']), |
There was a problem hiding this comment.
can you pep8 this (I mean all of it for good measure)?
baus/datasources.py
Outdated
|
|
||
| cnts = df.geom_id.isin(parcels.geom_id).value_counts() | ||
| cnts = df.parcel_id.isin(parcels.index).value_counts() | ||
| if False in cnts.index: | ||
| print "%d MISSING GEOMIDS!" % cnts.loc[False] |
There was a problem hiding this comment.
probably need to change this comment to take out GEOMIDS. Does is print anything? Do all the projects get mapped to reasonable parcel ids? I mean, have you checked to see if it works?
|
Hmm, I think we should just have development_projects.csv and not development_projects_w_apn.csv in github. Will keep us from file proliferation. Just copy it over once you've got it... |
fscottfoti
reviewed
May 3, 2018
baus/datasources.py
Outdated
| "development_projects_w_apn.csv")) | ||
| # find nearest parcel centroid to dev project x, y and assign parcel_id | ||
| df = pd.merge(df, parcels.apn.reset_index(), how='left', left_on='apn', | ||
| right_on='apn') |
There was a problem hiding this comment.
I like this merge. Clever way to merge to a series - I hadn't seen that before.
mxndrwgrdnr
pushed a commit
to ual/bayarea_urbansim
that referenced
this pull request
Mar 26, 2020
Strategies (futures round 2) prep work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update datasources to handle updated develpment projects data format by pulling parcel_id from x, y rather than geom_id.