Makefile: Add deps-ubuntu target #12
Conversation
Co-authored-by: Robert Sachunsky <[email protected]>
|
I will also open a pull request on ocrd-all when this get merged. |
Splendid. If you do, just add a line… deps-ubuntu: ocrd_pagetopdf…above the existing rules for ocrd-pagetopdf. |
Makefile
Outdated
| @echo "" | ||
| @echo " Variables" | ||
| @echo "" | ||
| @echo " PREFIX Directory to install to ('$(PREFIX)')" | ||
|
|
||
| # END-EVAL | ||
|
|
||
| # Install system packages (on Debian/Ubuntu) | ||
| deps-ubuntu: | ||
| apt-get install -y make python3 python3-pip python3-venv openjdk-8-jre-headless ghostscript |
There was a problem hiding this comment.
How would I run this rule if make was not already installed?
There was a problem hiding this comment.
True, make is redundant at this point.
There was a problem hiding this comment.
Nor do we need python3-pip, as pip gets installed with a Python3 venv.
|
@kba, can I merge with my changes? |
Remove the unneeded packages `make` (already required earlier) and `python3-pip` (not needed when using venv).
|
@sulzbals, thank you for your contribution. |
| @echo "" | ||
| @echo " Variables" | ||
| @echo "" | ||
| @echo " PREFIX Directory to install to ('$(PREFIX)')" | ||
|
|
||
| # END-EVAL | ||
|
|
||
| # Install system packages (on Debian/Ubuntu) | ||
| deps-ubuntu: | ||
| apt-get install -y python3 python3-venv openjdk-8-jre-headless ghostscript |
There was a problem hiding this comment.
Would openjdk-11-jre-headless also work? Newer Linux distributions don't provide JRE 8.
There was a problem hiding this comment.
No, the PRImA libs still require JRE 8 AFAIK (dimly recall getting that answer directly from Christian Clausner somewhere). Unfortunately, build and deps are not well documented for PRImA's projects, but you can open an issue about it on https://github.com/PRImA-Research-Lab/prima-core-libs or https://github.com/PRImA-Research-Lab/prima-page-converter.
Add target for installing the system dependencies listed in the README on a Debian/Ubuntu system.
Follows the same naming format of other ocrd modules (e.g. core), and could be used by ocrd-all when installing this module (I had to install
openjdkmanually after installing this with ocrd-all).