Add unmock function #212
Add unmock function #212
Conversation
Chemaclass
requested review from
cmayo,
khru,
JesusValeraDev,
antonio-gg-dev and
fabriziofs
src/runner.sh
Outdated
| @@ -127,6 +127,7 @@ function runner::run_test() { | |||
| "$function_name" "$data" 2>&1 1>&3 | |||
|
|
|||
| runner::run_tear_down | |||
| runner::clean_mocks | |||
There was a problem hiding this comment.
I added them to tests/acceptance/mock_test.sh
There was a problem hiding this comment.
we are also missing unit test of the function, no?
There was a problem hiding this comment.
Could you give me a hint how would you write unit tests for runner::clear_mocks()?
src/runner.sh
Outdated
| @@ -189,6 +190,12 @@ function runner::run_tear_down() { | |||
| helper::execute_function_if_exists 'tear_down' | |||
| } | |||
|
|
|||
| function runner::clean_mocks() { | |||
src/runner.sh
Outdated
| @@ -127,6 +127,7 @@ function runner::run_test() { | |||
| "$function_name" "$data" 2>&1 1>&3 | |||
|
|
|||
| runner::run_tear_down | |||
| runner::clean_mocks | |||
There was a problem hiding this comment.
we are also missing unit test of the function, no?
| function test_runner_clean_mocks_2() { | ||
| assert_is_not_mock ls | ||
| assert_is_not_mock ps | ||
| } |
There was a problem hiding this comment.
These test are not acceptance test, and the behavior you are trying to test it's not clear
|
@Chemaclass this is more complex than we anticipated, do you mind if we leave it in draft until we can get together? Besides, I think it's more priority to refactor the acceptance tests and finish the snapshots. |
Chemaclass
force-pushed
the
feat/unmock
branch
from
3340c23 to
cebb41c
Compare
|
Close because inactivity. I will open it again to seek for new feedback |
📚 Description
Currently, you can mock a particular function with custom logic, but there is no way to rollback the mock for other tests. It would be useful to be able to remove/rollback the mocked behaviour.
🔖 Changes
All mocks will be removed/rollback to their original behaviour after each test.
This means that the mock live scope is tied to the test scope
✅ To-do list
CHANGELOG.mdto reflect the new feature or fix