Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perk/spell classes to icons #403

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Psionyde
Copy link

Added "perk" and "spell" classes to the relevant icons for ease of selecting in, and futureproofing of, wikilink userscript.

(Would ideally like to integrate linking directly but there's further considerations before going down that road)

Not hugely familiar with React so apologies if I've missed anything.

Copy link
Owner

@TwoAbove TwoAbove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it would be great if they were "icon-perk" and "icon-spell" - less ambiguous about what they are about

@TwoAbove
Copy link
Owner

@Psionyde Just an FYI, I'll add linking directly by Feb, so might not be needed

@Psionyde
Copy link
Author

Actually, it would be great if they were "icon-perk" and "icon-spell" - less ambiguous about what they are about

Yep, good call, updated.

Just an FYI, I'll add linking directly by Feb, so might not be needed

Poggin. Still been a great learning exercise either way :>

@Psionyde Psionyde requested a review from TwoAbove January 25, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants