Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit asset timeframe partitions #1012

Merged
merged 4 commits into from
Feb 5, 2025

Conversation

datejada
Copy link
Member

@datejada datejada commented Feb 4, 2025

This PR unifies the default value of the partitions for the representatives and the timeframe. So, if no data is defined in the partition files, the default partition is uniform of value 1.

Related issues

Closes #1009

Checklist

  • I am following the contributing guidelines

  • Tests are passing

  • Lint workflow is passing

  • Docs were updated and workflow is passing

@datejada datejada added the benchmark PR only - Run benchmark on PR label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Benchmark Results

Benchmark in progress...

@datejada
Copy link
Member Author

datejada commented Feb 5, 2025

@abelsiqueira so, from the benchmark we can see the performance problem when we have several representatives and we use the constraints over clustered year (inter-temporal constraints) by defining the timeframe partitions.

The PR #1013 has the equivalent EU case study files in version 0.10.4 to have a reference.

Also, Joaquim and Oscar recommended PProf.jl find type instabilities and bottlenecks in the code. I will give it a try on a different PR.

I will keep you posted

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, small simple change, pre-approved.
It is a bit concerning that this doesn't break the tests at all. It's either not affecting anything, or affecting things that don't change anything. Either way, it's another thing we have to create tests for.
Maybe we modify Norse to remove one of the rows in assets-timeframe-partitions.csv?

src/tmp.jl Outdated Show resolved Hide resolved
Co-authored-by: Abel Soares Siqueira <[email protected]>
@datejada datejada removed the benchmark PR only - Run benchmark on PR label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (8ee7150) to head (f7a024f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          29       29           
  Lines        1151     1152    +1     
=======================================
+ Hits         1096     1097    +1     
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datejada datejada marked this pull request as ready for review February 5, 2025 14:00
@datejada
Copy link
Member Author

datejada commented Feb 5, 2025

Thanks, small simple change, pre-approved. It is a bit concerning that this doesn't break the tests at all. It's either not affecting anything, or affecting things that don't change anything. Either way, it's another thing we have to create tests for. Maybe we modify Norse to remove one of the rows in assets-timeframe-partitions.csv?

Thanks @abelsiqueira! I have updated the Storage case since it used the uniform partition = 1, so it does not change anything in the case study. In addition, I have updated the docs to mention the defaults and files that are allowed to be missing, and I have also updated the concepts section as a consequence.

Once the tests pass, I will merge them; thanks!

@datejada datejada merged commit d7cba2a into main Feb 5, 2025
7 checks passed
@datejada datejada deleted the 1009-allow-explicit-timeframe-partitions branch February 5, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default values for assets_timeframe_partitions table
2 participants