Update ghost.json #21826
Update ghost.json #21826
Conversation
Corregides formes incorrectes de: * Direcció -> Adreça * Subscribir-te -> Subscriure't (Ambdues són barbarismes). * Si us plau -> Si-us-plau Corregit typo de "seguro" a "segur".
|
Hi @Zagur ! Do you have a moment to review these Catalan refinements? |
|
Hi @Zagur ! Do you have a moment to review these Catalan refinements? |
Fixed two imperatives to replace inifinitives for actions
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
WalkthroughThis pull request focuses on refining the Catalan translations in the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ghost/i18n/locales/ca/ghost.json (1)
15-15: Consider using standard forms of "si us plau".While "si-us-plau" is understandable, the Institut d'Estudis Catalans (IEC) recommends either:
- "si us plau" (separate words)
- "sisplau" (one word)
These forms are more commonly used in modern Catalan.
- "Please confirm your email address with this link:": "Si-us-plau, confirma la teva adreça de correu electrònic amb aquest enllaç:", + "Please confirm your email address with this link:": "Si us plau, confirma la teva adreça de correu electrònic amb aquest enllaç:",- "You're one tap away from subscribing to {{siteTitle}} — please confirm your email address with this link:": "Estàs a un sol pas de subscriure't a {{siteTitle}} — si-us-plau, confirma la teva adreça de correu electrònic amb aquest enllaç:", + "You're one tap away from subscribing to {{siteTitle}} — please confirm your email address with this link:": "Estàs a un sol pas de subscriure't a {{siteTitle}} — si us plau, confirma la teva adreça de correu electrònic amb aquest enllaç:",Also applies to: 32-32
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ghost/i18n/locales/ca/ghost.json(1 hunks)
🔇 Additional comments (4)
ghost/i18n/locales/ca/ghost.json (4)
2-2: Well-chosen greetings and farewells!The translations are natural and idiomatic in Catalan. "Que et vagi bé!" is an excellent choice for "All the best!" as it's commonly used in everyday Catalan conversations.
Also applies to: 17-17
5-5: Correct usage of "adreça" for email address!The consistent use of "adreça de correu electrònic" instead of "direcció" is linguistically accurate and aligns with proper Catalan terminology.
Also applies to: 7-7, 26-26
16-16: Appropriate corrections in sign-in related text!The change from "seguro" to "segur" fixes the Spanish barbarism, and the sign-in translations are consistently implemented across all occurrences.
Also applies to: 19-19, 20-20
23-25: Correct implementation of "subscriure't"!The change from "subscribir-te" to "subscriure't" properly fixes the barbarism and follows correct Catalan grammar rules for verb conjugation and pronoun placement.
Also applies to: 32-33
|
@Hana-Gausfain and @alexrodba : Last question from me before merge time: "si us plau" vs "si-us-plau" ? Googling seems to favor unhyphenated, but I see that this PR changes it to hyphenated. (Hana-Gausfain's previous PR did not.) I'm not a Catalan speaker (and it's OK to ignore the recommendations from the AI bunny here), but just wanted to confirm that hyphenated is correct, rather than spending the next couple years adding and removing hyphens! 🤣 |
|
@cathysarisky I've reviewed the Catalan translation changes and they look excellent. The changes correctly implement:
Additionally, there are some good improvements to the translations that make them more natural and consistent. I recommend approving these changes. 🔗 Analysis chain🏁 Scripts executedThe following scripts were executed for the analysis: Script: Length of output: 2200 Script: Length of output: 43 Script: Length of output: 8946 ✅ Actions performedComments resolved. |
The hyphenated form is incorrect. The correct spelling in Catalan is "Si us plau." I'm not sure if the use of hyphens was a typo or a misunderstanding, but in Catalan, it is written without them. |
|
Actually, it seems they removed the hyphens obligation in the 90s, so I was wrong about that. My mistake. The correct form is "si us plau".
Best,
*
*
*Àlex Rodríguez Bacardit*
Founder & CEO / +34 659021169 ( tel:%2B34%20659021169 )
MarsBased
…On Wed, Jan 29, 2025 at 17:27:06, Don T3rr0rz0n3 < ***@***.*** > wrote:
>
>
> @ Hana-Gausfain ( https://github.com/Hana-Gausfain ) and @ alexrodba (
> https://github.com/alexrodba ) : Last question from me before merge time:
> "si us plau" vs "si-us-plau" ? Googling seems to favor unhyphenated, but I
> see that this PR changes it to hyphenated. (Hana-Gausfain's previous PR
> did not.) I'm not a Catalan speaker (and it's OK to ignore the
> recommendations from the AI bunny here), but just wanted to confirm that
> hyphenated is correct, rather than spending the next couple years adding
> and removing hyphens! 🤣
>
>
The hyphenated form is incorrect. The correct spelling in Catalan is "Si
us plau." I'm not sure if the use of hyphens was a typo or a
misunderstanding, but in Catalan, it is written without them.
—
Reply to this email directly, view it on GitHub (
#21826 (comment) ) , or
unsubscribe (
https://github.com/notifications/unsubscribe-auth/ABSBDJ6K7OPL4PZG6SEYQHD2ND6NVAVCNFSM6AAAAABTHSOY4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRSGEZDCMJRGU
).
You are receiving this because you were mentioned. Message ID: <TryGhost/Ghost/pull/21826/c2622121115
@ github. com>
|
There was a problem hiding this comment.
@alexrodba , I can't remove the hyphens for you, but I've left you suggestions you can commit to do so. :) I think this is ready to go otherwise?
Co-authored-by: Cathy Sarisky <[email protected]>
Co-authored-by: Cathy Sarisky <[email protected]>
Corregides formes incorrectes de:
Corregit typo de "seguro" a "segur".
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:allandyarn lint)We appreciate your contribution!