🐛 Fixed image resizing when sharp is not installed #10415
Conversation
refs #10181 The ghost-ignition library overrides any passed props such as `code` when passing an error, this fix removes the original `err.code` so that we can be explicit in which errors we are throwing and catching.
|
@kirrg001 What do you think of this - rather than fixing in ghost-ignition and bumping it? I think it would be a breaking change to ignition |
|
@allouis I think it can wait for Monday? What do you think? I remember image manipulation can be disabled temporary or? |
IMO Ignition should respect |
I agree, the only problem is that it's a major change, and we'll have to check that nothing is relying on current behaviour!
Not sure what you mean by this? You mean fix ignition on Monday? |
This report is not critical IMO. Something to work on bug fix Monday? |
|
Yeah |
|
Yeah i guess we close this PR for now and raise a proper bug fix issue, which get's the correct priority on the project board :) |
refs TryGhost/Ghost#10415 refs TryGhost/Ghost#10181 refs TryGhost/Ghost#10421 When supplying a code to an ignition error, if you pass an error with a code, the error's code takes precedence rather than the explicit code you pass.
|
Closing as this will be fixed in Ignition |
refs #10181
The ghost-ignition library overrides any passed props such as
codewhen passing an error, this fix removes the original
err.codeso thatwe can be explicit in which errors we are throwing and catching.