Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding resizable images #10183

Closed
wants to merge 9 commits into from
Closed

Adding resizable images #10183

wants to merge 9 commits into from

Conversation

notanengineercom
Copy link
Contributor

#10181
I worked this weekend and added the ability of resizing images. They are being declared in the config.json (disabled by default). I also changed a bit of the sharp image function, with better image compression and added an optional deletion of the original image.

@notanengineercom notanengineercom mentioned this pull request Nov 19, 2018
4 tasks
@kirrg001
Copy link
Contributor

kirrg001 commented Dec 3, 2018

@allouis As you took over #10181, could you please reply to this PR? Thanks 👍

@allouis
Copy link
Contributor

allouis commented Dec 4, 2018

hey @notanengineercom Thanks for your contribution ☺️ As was mentioned in #10181 we need something a little more flexible and preferably without adding extra deps! I'm going to close this as we already have something put together which satisfies this. Thanks again 👻

@allouis allouis closed this Dec 4, 2018
@notanengineercom
Copy link
Contributor Author

@allouis yes sure, no problem. I just recommend you considering imagemin, because sharp (even though it's the fastest) makes image files bigger in size when you upload an optimized pictures (so when you scale down the image it's often bigger than the original).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants