Significantly improve values parsing for 1.15.5 and 6

TrinityCore · Feb 8, 2025 · 3bf2f4e · 3bf2f4e
1 parent 1adc6d3
commit 3bf2f4e
Show file tree

Hide file tree

Showing 7 changed files with 228 additions and 302 deletions.
diff --git a/WowPacketParser/Enums/Version/V1_15_5_57638/Opcodes.cs b/WowPacketParser/Enums/Version/V1_15_5_57638/Opcodes.cs
@@ -2115,7 +2115,7 @@ public static BiDictionary<Opcode, int> Opcodes(Direction direction)
             { Opcode.SMSG_WHO_IS, 0x37013E },
             { Opcode.SMSG_WILL_BE_KICKED_FOR_ADDED_SUBSCRIPTION_TIME, 0x3702B5 },
             { Opcode.SMSG_WORLD_QUEST_UPDATE_RESPONSE, 0x4A0017 },
-            { Opcode.SMSG_WORLD_SERVER_INFO, 0x370045 },
+            { Opcode.SMSG_WORLD_SERVER_INFO, 0x3B0045 },
             { Opcode.SMSG_WOW_ENTITLEMENT_NOTIFICATION, 0x3702E4 },
             { Opcode.SMSG_WOW_LABS_AREA_INFO, 0x370317 },
             { Opcode.SMSG_WOW_LABS_NOTIFY_PLAYERS_MATCH_END, 0x370313 },

diff --git a/WowPacketParser/Enums/Version/V1_15_6_58797/Opcodes.cs b/WowPacketParser/Enums/Version/V1_15_6_58797/Opcodes.cs
@@ -2115,7 +2115,7 @@ public static BiDictionary<Opcode, int> Opcodes(Direction direction)
             { Opcode.SMSG_WHO_IS, 0x37013E },
             { Opcode.SMSG_WILL_BE_KICKED_FOR_ADDED_SUBSCRIPTION_TIME, 0x3702B5 },
             { Opcode.SMSG_WORLD_QUEST_UPDATE_RESPONSE, 0x4A0017 },
-            { Opcode.SMSG_WORLD_SERVER_INFO, 0x370045 },
+            { Opcode.SMSG_WORLD_SERVER_INFO, 0x3B0046 },
             { Opcode.SMSG_WOW_ENTITLEMENT_NOTIFICATION, 0x3702E4 },
             { Opcode.SMSG_WOW_LABS_AREA_INFO, 0x370317 },
             { Opcode.SMSG_WOW_LABS_NOTIFY_PLAYERS_MATCH_END, 0x370313 },

diff --git a/WowPacketParserModule.V4_4_0_54481/Parsers/UpdateFieldsHandler1155.cs b/WowPacketParserModule.V4_4_0_54481/Parsers/UpdateFieldsHandler1155.cs
@@ -3911,6 +3911,7 @@ public override IActivePlayerData ReadCreateActivePlayerData(Packet packet, Upda
         public override IActivePlayerData ReadUpdateActivePlayerData(Packet packet, params object[] indexes)
         {
             var data = new ActivePlayerData();
+            /*
             packet.ResetBitReader();
             var rawChangesMask = new int[48];
             var rawMaskMask = new int[2];
@@ -4593,7 +4594,7 @@ public override IActivePlayerData ReadUpdateActivePlayerData(Packet packet, para
                 }
                 if (changesMask[69])
                 {
-                    /*data.SpellCritPercentage = */packet.ReadSingle("SpellCritPercentage", indexes);
+                    // data.SpellCritPercentage = packet.ReadSingle("SpellCritPercentage", indexes);
                 }
             }
             if (changesMask[70])
@@ -4874,7 +4875,7 @@ public override IActivePlayerData ReadUpdateActivePlayerData(Packet packet, para
                 {
                     if (hasQuestSession)
                     {
-                        /*data.QuestSession =*/ ReadUpdateQuestSession(packet, indexes, "QuestSession");
+                        // data.QuestSession = ReadUpdateQuestSession(packet, indexes, "QuestSession");
                     }
                 }
                 if (changesMask[124])
@@ -4883,7 +4884,7 @@ public override IActivePlayerData ReadUpdateActivePlayerData(Packet packet, para
                 }
                 if (changesMask[126])
                 {
-                    /*data.Field_1410 =*/ ReadUpdateActivePlayerUnk901(packet, indexes, "Field_1410");
+                    // data.Field_1410 = ReadUpdateActivePlayerUnk901(packet, indexes, "Field_1410");
                 }
                 if (changesMask[132])
                 {
@@ -5053,7 +5054,7 @@ public override IActivePlayerData ReadUpdateActivePlayerData(Packet packet, para
                         data.ItemUpgradeHighWatermark[i] = packet.ReadSingle("ItemUpgradeHighWatermark", indexes, i);
                     }
                 }
-            }
+            }*/
             return data;
         }