fix(utils/dynamicRequire): get rid of Webpack Critical dependency warning #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the Webpack warning: "WARNING in ./src/public/app/services/utils.ts 249:15-34 Critical dependency: the request of a dependency is an expression" as we now explicitly pass the moduleName as string and not "expression" source: https://stackoverflow.com/questions/42908116/
pano9000
force-pushed
the
fix_webpack-warning
branch
from
4ba9fc2 to
d56752e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR aims to get rid of the Webpack warning that appears when running webpack:
It does it by simply explicitly passing the moduleName as string using template literal and not the moduleName "expression",
Source: https://stackoverflow.com/questions/42908116/