Adding new functions this_line, this_file, this_counter #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
requested changes
Jan 8, 2021
| @end table | ||
|
|
||
| @node Conditional Functions, Foreach Function, File Name Functions, Functions |
There was a problem hiding this comment.
I'm getting an in build because this @node line is missing:
make
Making all in lib
make[1]: Entering directory '/tmp/remake/lib'
make.texi:12429: @xref reference to nonexistent node `Conditional Functions'
make.texi:12435: @xref reference to nonexistent node `Conditional Functions'
make.texi:12442: @xref reference to nonexistent node `Conditional Functions'
make.texi:7030: @menu reference to nonexistent node `Conditional Functions'
make.texi:278: @detailmenu reference to nonexistent node `Conditional Functions'
make.texi:7455: Next reference to nonexistent `Conditional Functions'
make.texi:7708: Prev reference to nonexistent `Conditional Functions'
Makefile:918: *** [make.info] error 1
There was a problem hiding this comment.
Could you help (perhaps by patching the pull request). I am not familiar witrh texinfo. But you could use the C code and improve/correct the documentation. Thanks. Basile Starynkevitch
There was a problem hiding this comment.
Ok - #116 started. (I thought when you open a PR there's a button that allows maintainers to add more commits. I didn't see that here so a new PR was started).
I don't see though that the this_ functions do anything. See that PR for details.
rocky
force-pushed
the
remake-4-3
branch
5 times, most recently
from
269a076 to
3048790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add new functions :
$(this_line)- inspired by__LINE__in C and expanded to the current file name (e.g.Makefile)$(this_file)- inspired by__FILE__in C and expanded to the current line number (e.g.123if appearing in line 123 of yourGNUmakefile$(this_counter), inspired by__COUNTER__from GCC preprocessorThe documentation is wrong and needs some fix.
Also, the
GNUremakefileis also considered as a name.