Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GitHub Actions workflow on Linux and macOS #26

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Jun 17, 2024

This PR extends the GitHub Actions workflow for 5.2 execute on macOS and Linux.
Even though macOS only has bash 3.x by default, AFAIK manu use Homebrew to install and use a recent version Bash.

With this matrix build setup, the CI runtime is still under one minute: https://github.com/rocky/bashdb/actions/runs/9548882962

This PR is not installing pygments because an attempt failed due to excessive runtime. When I debugged this on a local macOS setup via ssh, running bashdb's osascript -e 'tell application "Terminal" to get the background color of the current settings of the selected tab of front window' did not return unless there was a logged in user session. I'm not able to reproduce this reliably in different sessions and across restarts, though.

@jansorg jansorg force-pushed the jansorg/5.2-github-actions-mac branch 6 times, most recently from c439ecd to e0016c2 Compare June 17, 2024 13:12
@jansorg jansorg changed the title wip: Run GitHub Actions workflow on Linux and macOS Run GitHub Actions workflow on Linux and macOS Jun 17, 2024
@jansorg jansorg force-pushed the jansorg/5.2-github-actions-mac branch from e0016c2 to bf6322d Compare June 17, 2024 13:19
@jansorg jansorg force-pushed the jansorg/5.2-github-actions-mac branch from bf6322d to 5587a2e Compare June 17, 2024 13:48
@jansorg jansorg marked this pull request as ready for review June 17, 2024 13:49
@jansorg jansorg requested a review from rocky June 17, 2024 13:52
Copy link
Collaborator

@rocky rocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit a0e8d73 into bash-5.2 Jun 17, 2024
3 checks passed
@jansorg jansorg deleted the jansorg/5.2-github-actions-mac branch June 17, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants