5.2: Rewrite "info variables -p" #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocky
reviewed
Feb 13, 2024
| if ((_Dbg_typeset_filtered == 1)); then | ||
| # grepping for '=' to only accept variables with a value | ||
| mapfile -t _Dbg_var_names < <(declare -p $_Dbg_typeset_flags | | ||
| grep '=' | |
There was a problem hiding this comment.
Previously I have been shying away from assuming POSIX command-line arguments. MS windows for example in its native mode might not have "cut" and "grep -v" and "sort".
Creating this pipeline as a bash or zsh function should be doable. And we can test that in isolation.
There was a problem hiding this comment.
Thanks, I didn't think about Windows. I'll try to come up with equivalent Bash-only code...
…array keys and array values. Bash's "typeset -p" escapes line feeds and other special characters and wraps such values in $''. Array keys with spaces are wrapped into "". Previously, $'' was kept but the escape codes were resolved. The escape codes are now retained in the output of "info variables" to show each variable and its value on a single line. This is to improve readability and help programmatic parsing of the variable listing.
jansorg
force-pushed
the
5.1-jansorg-info-variables
branch
from
2a19158 to
d1fb20c
Compare
|
Superseded by #23 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite
info variablesto support line feeds and spaces in values, array keys and array values.Bash's
typeset -pescapes line feeds and other special characters and wraps such values in$''. Array keys with spaces are wrapped into"". Previously,$''was kept but the escape codes were resolved. The escape codes are now retained in the output ofinfo variablesto show each variable and its value on a single line. This is to improve readability and help programmatic parsing of the variable listing.