Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.2: Fix pollution with global variables #10

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Feb 13, 2024

Fixes some of the pollution with global variables.

We're dropping the default of s/step for the "last command", because it's breaking tests and is potentially confusing to users. Previously, the default was not applied because the other places used a _Dbg_ prefix (i.e. the name here was wrong and the default was not used).

@rocky
Copy link
Collaborator

rocky commented Feb 13, 2024

I really like this!

However, when I try it things are failing for me. Let me see if I can get CircleCI working for this first.

@jansorg
Copy link
Collaborator Author

jansorg commented Feb 13, 2024

I think that tests were passing locally...
Any objections if I tried to add GitHub Actions CI in addition to your Circle CI setup?

@rocky
Copy link
Collaborator

rocky commented Feb 13, 2024

I think that tests were passing locally... Any objections if I tried to add GitHub Actions CI in addition to your Circle CI setup?

This would be awesome. Please do it!

… seem to use "_Dbg_last_next_step_cmd" already.

We're dropping the default of "step" because it's breaking tests.
@jansorg jansorg force-pushed the 5.1-jansorg-fix-var-pollution branch from fd7e748 to b80efe0 Compare February 14, 2024 15:22
@rocky
Copy link
Collaborator

rocky commented Feb 14, 2024

We're dropping the default of s/step for the "last command", because it's breaking tests and is potentially confusing to users.

All good -

I just checked the behavior of gdb 14.0.50 and it does not default to s/step initially either. However after a step is done, that hitting enter will continue stepping. And that is how bashdb works even after this change.

@rocky
Copy link
Collaborator

rocky commented Feb 14, 2024

Testing now works for me. Many thanks!

@rocky rocky merged commit 7687d3e into bash-5.2 Feb 14, 2024
2 checks passed
@jansorg jansorg deleted the 5.1-jansorg-fix-var-pollution branch February 14, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants