Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stackbit Integration #98

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Stackbit Integration #98

wants to merge 5 commits into from

Conversation

RistoBIn
Copy link

@RistoBIn RistoBIn commented Sep 10, 2019

This pull request add's Stackbit to this Hugo theme. It add's the stackbit.yaml file which makes this theme work with several headless CMS automatically (including Forestry, NetlifyCMS, DatoCMS & Contentful) and it deploys the site to Netlify in 1 click.

You can try it out: https://app.stackbit.com/create?theme=https://github.com/stackbithq/hermit (note the "create with stackbit" button in the readme will import the theme from your repo so until the PR is merged it wont work)

I think this is really valuable and is a very low impact addition on your existing theme structure. Pretty much just the stackbit.yaml file. If you have questions or feedback I'm happy to discuss.

Risto

Copy link
Owner

@Track3 Track3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is really cool, many thanks for your great work!

I noticed the netlify.toml file is modified, this repo relies on netlify for automatic publishing and deploy previews, can we avoid this modification but still keeps Stackbit working?

@RistoBIn
Copy link
Author

yes, netlify.toml was modified.
Btw, automatic building in netlify will be working.
Is that not working?

@Track3
Copy link
Owner

Track3 commented Oct 27, 2019

Although it didn't say build failed, the build command is not correct. as you can see below deploy log, full log can be found here

4:47:59 PM: No build command found, continuing to publishing
4:47:59 PM: Starting to deploy site from ''

This repo use the exampleSite/ folder as Hugo base directory, so theme directory is ../... This is different from a normal hugo site repo (usually uses repo's root as the base dir).

@RistoBIn RistoBIn force-pushed the master branch 3 times, most recently from 5d9dc9e to 3f5749a Compare October 28, 2019 17:52
@RistoBIn
Copy link
Author

Stackbit system build also based on /example folder.
If building is not failed, we may use this netlify.toml.
Because, stackbit will occur issue with original netlify.toml.
Hope to know your expectation.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants