Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added initial implementation for Google Cloud Storage #1558

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amankrx
Copy link

@amankrx amankrx commented Jan 9, 2025

Description

This PR implements the Google Cloud Store implementation and closely aligns with the AWS S3 implementation.
This utilizes the google protos. There were three primary options that I considered here (gcloud_sdk_rs, googleapis-tonic-google-storage-control-v2, or building it locally). Out of all these three options, googleapis-tonic-google-storage-control-v2 seemed to have the easiest approach to just use the rust bindings, without importing a number of libraries like reqwest, etc.

Following the same approach I used for Azure Blob Storage, I started my development by first creating a POC: https://gist.github.com/amankrx/d3861756e00e0d5157cd4230477b4024
This POC tests the operations that we will be performing in the real implementation.

A few points to consider:

  • This still requires an E2E testing to confirm that it works.
  • This just has one way of authentication at the moment i.e.: using token, and that is valid for an hour.
  • I will have to add some integration tests along with a Mock client.

Fixes #659
/claim #659

Type of change

Please delete options that aren't relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • Local tests completed
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@asr2003
Copy link

asr2003 commented Jan 9, 2025

Similar to #1547

Dear reviewers, There are many ways to do, I have connected with Community and finally approached with tonic/grpc solution. I do argue to get my PR reviewed first as I have went throughout many discussions with community members and landed solution there. Just waiting to the response from reviewers of mocking client approach we going to take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💎 Implement Google Cloud Bucket Store
2 participants