Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue973 generate rays #975

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Issue973 generate rays #975

merged 10 commits into from
Sep 13, 2024

Conversation

Didou09
Copy link
Member

@Didou09 Didou09 commented Sep 13, 2024

Main changes:

  • add_rays_from_diagnostic() implemented

    • only for pinhole cameras
    • only for non-spectro diags
    • only for random strategy
    • without vignetting
  • Minor cleanup of code:

    • more robust plot_diagnoctic_geometrical_coverage() vs key of diag
    • fixed compile-time warning from nogil vs except
    • Pins setuptools to be !=65.* and !=74.*
  • Minor bug fix in vignetting tools on indexing

Issues:

Partially fixes, in devel, issue #973 , but only with random sampling and without vignetting

Fixes, in devel:

Opens issue #974

Example:

coll.add_rays_from_diagnostic(config=conf)
dax = coll.plot_rays('cup0_cam_rays_random', plot_config=conf)

coll.save_rays_to_stp(key='cup0_cam_rays_random', factor=1000, color='r', overwrite=True)
Saved to:
	C:\Users\dvezinet\Documents\Projects\tofu_sparc\cup0_cam_rays_random.stp

image

@pep8speaks
Copy link

pep8speaks commented Sep 13, 2024

Hello @Didou09! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 401:2: W292 no newline at end of file

Line 179:5: E303 too many blank lines (2)
Line 373:5: E303 too many blank lines (2)
Line 479:5: E303 too many blank lines (2)
Line 491:5: E303 too many blank lines (2)
Line 530:11: W292 no newline at end of file

Comment last updated at 2024-09-13 11:06:49 UTC

@Didou09 Didou09 merged commit c5ea3e5 into devel Sep 13, 2024
14 checks passed
@Didou09 Didou09 deleted the Issue973_GenerateRays branch September 13, 2024 11:29
@Didou09 Didou09 mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants