-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add ZarrTIFFWSIReader class. #897
base: develop
Are you sure you want to change the base?
Conversation
3805565
to
cbd657f
Compare
bfa8b4b
to
1bc2356
Compare
for more information, see https://pre-commit.ci
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #897 +/- ##
===========================================
- Coverage 99.90% 99.23% -0.68%
===========================================
Files 69 69
Lines 8715 8786 +71
Branches 1149 1160 +11
===========================================
+ Hits 8707 8719 +12
- Misses 3 61 +58
- Partials 5 6 +1 ☔ View full report in Codecov by Sentry. |
tiatoolbox/wsicore/wsireader.py
Outdated
Args: | ||
path (Path): Path to the file to check. | ||
|
||
# TODO extend logic and verify that json file is a fsspec tiff file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a link to tiff-fsspec generator file.
tiatoolbox/wsicore/wsireader.py
Outdated
@@ -4225,6 +4246,528 @@ class docstrings for more information. | |||
return im_region | |||
|
|||
|
|||
class ZarrTIFFWSIReader(WSIReader): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to appropriate name e.g., fsspecWSIReader.
tiatoolbox/wsicore/wsireader.py
Outdated
@@ -4225,6 +4246,528 @@ class docstrings for more information. | |||
return im_region | |||
|
|||
|
|||
class ZarrTIFFWSIReader(WSIReader): | |||
"""Define Zarr Tiff WSI Reader.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some documentation / introduction about the fsspec / json files.
The ZarrTIFFWSIReader reads fsspec json file which represents SVS wsi.
The methods: read_rect, read_bounds, _canonical_shape are copied from TIFFWSIReader, and it needs to be improved by introducing delegates or some other way.
The method infor reads SVS metadata which is stored in the root group metadata like:
To test, execute from the root dir:
Change the svs variable inside of
tileserver.py
to:svs = "../../samples/fsspec/73c69d24-6f9e-44e2-bfe5-a608d4cf5c27_fsspec.json"
python tileserver.py
Open
http://127.0.0.1:5000/
and verify how it works.