Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated resolution of images in document #281

Merged
merged 6 commits into from
Sep 9, 2024
Merged

Conversation

engrvip123
Copy link
Contributor

Images added in info.md were not rendering properly in datasheet pdf document.

@urish
Copy link
Member

urish commented Sep 9, 2024

Thanks, but please also deelete .vscode/settings.json from the pull request

@engrvip123
Copy link
Contributor Author

Thanks, but please also deelete .vscode/settings.json from the pull request

Where does this file lie? How to delete it.

@urish
Copy link
Member

urish commented Sep 9, 2024

See under the "File changed" tab of the Pull Request:

image

@urish urish merged commit 0100351 into TinyTapeout:main Sep 9, 2024
@urish
Copy link
Member

urish commented Sep 9, 2024

Thanks!

@engrvip123
Copy link
Contributor Author

Why images are not visible in datasheet for my project? Earlier it was visible but after deleting .vscode/settings.json they are not.

@urish
Copy link
Member

urish commented Sep 9, 2024

They also don't appear on the website: https://www.tinytapeout.com/runs/tt08/tt_um_ssp_opamp

I'm not sure if <img> tags are supported by the markdown engine we use: https://github.com/TinyTapeout/tinytapeout_www/blob/9d01b4c3159c9b71e3cd3ae5f6c950b44c6e8c14/functions/components/ProjectPage.tsx#L28

@engrvip123
Copy link
Contributor Author

engrvip123 commented Sep 10, 2024

What syntax could be used to change image dimensions in markdown so that appear properly in final datasheet pdf??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants