Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): structure base backend code #11

Merged
merged 7 commits into from
Nov 8, 2024
Merged

feat(backend): structure base backend code #11

merged 7 commits into from
Nov 8, 2024

Conversation

tuantran0910
Copy link
Contributor

Description

Structure the codebase for Backend. The backend will be written under FastAPI.

@tuantran0910 tuantran0910 self-assigned this Nov 5, 2024
@tuantran0910 tuantran0910 linked an issue Nov 5, 2024 that may be closed by this pull request
Review current backend progress #7
Closed
@tuantran0910
Copy link
Contributor Author

#7

greyyT
greyyT reviewed Nov 5, 2024
View reviewed changes
backend/databases/postgres.py Outdated Show resolved Hide resolved
backend/main.py Outdated Show resolved Hide resolved
backend/models/error.py Outdated Show resolved Hide resolved
backend/repositories/embeding_model.py Outdated Show resolved Hide resolved
backend/routers/v1/embedding_model.py Outdated Show resolved Hide resolved
@tuantran0910
Copy link
Contributor Author

Please don't merge until I push the final code base which is able to run for testing.

@lelouvincx
Copy link
Collaborator

Please don't merge until I push the final code base which is able to run for testing.

You should change the PR to draft, shouldn't you?

@tuantran0910 tuantran0910 marked this pull request as draft November 6, 2024 03:13
@tuantran0910
Copy link
Contributor Author

Please don't merge until I push the final code base which is able to run for testing.

You should change the PR to draft, shouldn't you?

Yes. I have done it.

@lelouvincx lelouvincx added this to the MVP #1 milestone Nov 7, 2024
@tuantran0910 tuantran0910 marked this pull request as ready for review November 7, 2024 02:19
@tuantran0910 tuantran0910 requested a review from greyyT November 7, 2024 02:21
@tuantran0910 tuantran0910 added the enhancement New feature or request label Nov 7, 2024
greyyT
greyyT reviewed Nov 7, 2024
View reviewed changes
backend/databases/postgres.py Outdated Show resolved Hide resolved
backend/main.py Outdated Show resolved Hide resolved
backend/repositories/embeding_model.py Outdated Show resolved Hide resolved
backend/utils/error_handler.py Outdated Show resolved Hide resolved
@lelouvincx lelouvincx removed the feature label Nov 7, 2024
lelouvincx
lelouvincx reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@lelouvincx lelouvincx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvement requests. Still fine.

backend/Dockerfile Outdated Show resolved Hide resolved
backend/databases/postgres.py Show resolved Hide resolved
backend/databases/postgres.py Outdated Show resolved Hide resolved
backend/databases/postgres.py Outdated Show resolved Hide resolved
backend/models/embedding_model.py Outdated Show resolved Hide resolved
backend/routers/v1/embedding_model.py Show resolved Hide resolved
backend/routers/v1/embedding_model.py Show resolved Hide resolved
backend/utils/logger.py Outdated Show resolved Hide resolved
deployment/docker_compose/docker-compose.yaml Outdated Show resolved Hide resolved
lelouvincx
lelouvincx approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@lelouvincx lelouvincx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lelouvincx lelouvincx merged commit 5db22bb into main Nov 8, 2024
@lelouvincx lelouvincx deleted the feat/7-structure-backend-code branch November 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lelouvincx lelouvincx lelouvincx approved these changes

@vn01122003 vn01122003 Awaiting requested review from vn01122003

@greyyT greyyT Awaiting requested review from greyyT

Assignees

@tuantran0910 tuantran0910

Labels
enhancement New feature or request
Projects
Chat Bot
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review current backend progress
4 participants
@tuantran0910 @lelouvincx @greyyT @tuantrancake