Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve values in application, client, device, gateway and rights #7514

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

ryaplots
Copy link
Contributor

@ryaplots ryaplots commented Feb 19, 2025

Summary

Reserves values related to enterprise changes - https://github.com/TheThingsIndustries/lorawan-stack/pull/4542

Changes

  • Reserve values in application, end device, gateway, client and rights protos

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added the compat/api This could affect API compatibility label Feb 19, 2025
@ryaplots ryaplots added this to the v3.34.0 milestone Feb 19, 2025
@ryaplots ryaplots self-assigned this Feb 19, 2025
@ryaplots ryaplots requested a review from a team as a code owner February 19, 2025 11:44
@ryaplots ryaplots requested a review from nicholaspcr February 19, 2025 12:55
@ryaplots
Copy link
Contributor Author

@KrishnaIyer Can you merge this one too?

@KrishnaIyer KrishnaIyer merged commit 3e16fe8 into v3.34 Feb 19, 2025
13 of 14 checks passed
@KrishnaIyer KrishnaIyer deleted the fix/reserve-proto-definitions branch February 19, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat/api This could affect API compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants