Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update errWebhookDisabled attributes #7508

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

nicholaspcr
Copy link
Contributor

Summary

Backport of https://github.com/TheThingsIndustries/lorawan-stack/pull/4536

Changes

  • Add webhook_id and application_id attributes to webhook disabled error.

Testing

Steps

CI

Notes for Reviewers

This will be cherry picked into v3.33 for the new patch release.
Didn't add anything to the CHANGELOG because under this context is just an error attribute update.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@github-actions github-actions bot added the c/application server This is related to the Application Server label Feb 12, 2025
@nicholaspcr nicholaspcr marked this pull request as ready for review February 12, 2025 14:03
@nicholaspcr nicholaspcr requested a review from a team as a code owner February 12, 2025 14:03
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you.

@nicholaspcr nicholaspcr merged commit c23230a into v3.34 Feb 12, 2025
14 of 15 checks passed
@nicholaspcr nicholaspcr deleted the backport/update-webhook-disabled-error branch February 12, 2025 14:19
nicholaspcr added a commit that referenced this pull request Feb 12, 2025
…k-disabled-error

Update errWebhookDisabled attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/application server This is related to the Application Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants