Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter of end devices with startsWith #7476

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

ryaplots
Copy link
Contributor

Summary

References #7468

Changes

  • Remove startWith and improve end device filtering

Testing

Steps
  1. Create two applications with identical prefix for their application-ids
  2. Register devices in both
  3. Check the top end devices once they appear there

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@ryaplots ryaplots added c/console This is related to the Console ui/web This is related to a web interface labels Jan 16, 2025
@ryaplots ryaplots added this to the v3.33.1 milestone Jan 16, 2025
@ryaplots ryaplots self-assigned this Jan 16, 2025
@ryaplots ryaplots requested a review from a team as a code owner January 16, 2025 12:33
@PavelJankoski PavelJankoski merged commit 3c7671f into v3.33 Jan 22, 2025
12 of 13 checks passed
@PavelJankoski PavelJankoski deleted the fix/top-entities-devices branch January 22, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console This is related to the Console ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants