-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support NbTrans controls while using Dynamic ADR mode #7012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, LGTM!
Please wait with merging, I have a pending review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, but the devil is in the details here. Please see my suggestion about using valueSetter
to align the form values with the backend shape and avoiding custom data marshalling.
feature/adr-nbtrans-controls...feature/adr-nbtrans-controls-2
pkg/webui/console/views/device-general-settings/network-server-form/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/views/device-general-settings/network-server-form/validation-schema.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/views/device-general-settings/network-server-form/validation-schema.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/views/device-general-settings/network-server-form/index.js
Outdated
Show resolved
Hide resolved
pkg/webui/console/views/device-general-settings/network-server-form/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! See my two small remarks.
Summary
Closes #6966
Changes
Testing
Screen.Recording.2024-03-27.at.12.47.45.mp4
Use default settings for number of retransmissions
Add data rate specific override
and add the data rate and NbTransChecklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.