-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMX TCR Updates #806
Open
sjackle
wants to merge
12
commits into
TheThingsNetwork:master
Choose a base branch
from
pmx-systems:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PMX TCR Updates #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaime-Trinidad
approved these changes
Aug 1, 2024
HI @sjackle please run |
Hi Jaime |
@sjackle Please still run |
Jaime-Trinidad
approved these changes
Sep 9, 2024
Hi @sjackle please update the branch so I can merge it. Thanks |
Done. Updated branch, tested my entry and make validate fmt executed w/o issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Corrected a problem with the PMX TCR Codec
Added our LoRa Alliance Vendor ID
...
Changes
Checklist for Reviewers
profileIDs
should not bevendorID
and should be a unique value for every profile.index.yaml
file.Notes for Reviewers
...
Release Notes