Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure documentation #1394

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Restructure documentation #1394

wants to merge 30 commits into from

Conversation

KrishnaIyer
Copy link
Contributor

@KrishnaIyer KrishnaIyer commented Jan 13, 2025

Summary

Restructure documentation.

Changes

  • 98% of the content is just updating links and aliases.

  • Update aliases. Missing aliases checked using the alias check tool:

go run util/check-aliases.go
Check 841 URLs for changes
Original: 841, Unchanged: 841, Aliased: 0, Missing: 0
  • Small content improvements where necessary.

Screenshots

Screen Shot 2025-01-16 at 16 30 04
Screen Shot 2025-01-16 at 16 30 06
Screen Shot 2025-01-16 at 16 30 10
Screen Shot 2025-01-16 at 16 30 13
Screen Shot 2025-01-16 at 16 30 15
Screen Shot 2025-01-16 at 16 30 24

Notes for Reviewers

To do

  • Self review
  • Fill content holes
  • Check that aliases are correct

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@KrishnaIyer KrishnaIyer added this to the Jan 2025 milestone Jan 13, 2025
@KrishnaIyer KrishnaIyer self-assigned this Jan 13, 2025
| Component (Service) | Short | Description |
| ------------------------- | ----- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| Tenant Billing Server | `TBS` | Manages the creation, suspension and billing of tenants using different payment backends (only for {{% tts %}} cloud). |
| QR Generator | `QRG` | Generates QR codes for devices in various formats. These QR codes can be used for various purposes, including identification and device claiming to transfer ownership.. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| QR Generator | `QRG` | Generates QR codes for devices in various formats. These QR codes can be used for various purposes, including identification and device claiming to transfer ownership.. |
| QR Generator | `QRG` | Generates QR codes for devices in various formats. These QR codes can be used for various purposes, including identification and device claiming to transfer ownership.. |
Suggested change
| QR Generator | `QRG` | Generates QR codes for devices in various formats. These QR codes can be used for various purposes, including identification and device claiming to transfer ownership.. |
| QR Generator | `QRG` | Generates QR codes for devices in various formats. These QR codes can be used for various purposes, including identification and device claiming to transfer ownership. |

aliases: [the-things-stack/concepts/architecture]
---

{{% tts %}} follows a API driven microservice architecture, well suited for high availability and reliability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{% tts %}} follows a API driven microservice architecture, well suited for high availability and reliability.
{{% tts %}} follows an API driven microservice architecture, well suited for high availability and reliability.

@@ -14,11 +14,11 @@ This error usually occurs when wrong path(s) are specified in the `field_mask` o

###### When adding a device, I get an "invalid end_device: embedded message failed validation" error.

The most common cause for this error is not following the regex pattern in the `device_id` field. See [End Device APIs]({{< ref "/api/reference/grpc/end_device#message:EndDeviceIdentifiers" >}}) section and make sure your `device_id` is in line with the defined regex pattern. See also [ID and EUI constaints]({{< ref "/reference/id-eui-constraints" >}}) documentation.
The most common cause for this error is not following the regex pattern in the `device_id` field. See [End Device APIs]({{< ref "/api/reference/grpc/end_device#message:EndDeviceIdentifiers" >}}) section and make sure your `device_id` is in line with the defined regex pattern. See also [ID and EUI constaints]({{< ref "/concepts/architecture/id-eui-constraints" >}}) documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The most common cause for this error is not following the regex pattern in the `device_id` field. See [End Device APIs]({{< ref "/api/reference/grpc/end_device#message:EndDeviceIdentifiers" >}}) section and make sure your `device_id` is in line with the defined regex pattern. See also [ID and EUI constaints]({{< ref "/concepts/architecture/id-eui-constraints" >}}) documentation.
The most common cause for this error is not following the regex pattern in the `device_id` field. See [End Device APIs]({{< ref "/api/reference/grpc/end_device#message:EndDeviceIdentifiers" >}}) section and make sure your `device_id` is in line with the defined regex pattern. See also [ID and EUI constraints]({{< ref "/concepts/architecture/id-eui-constraints" >}}) documentation.

Copy link
Member

@johanstokking johanstokking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

Copy link
Contributor

@mjamescompton mjamescompton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, much prefer the new structure but we need to create 301 redirects for every URL change so that all our search results to go to 404s.

This a pain to do with hugo and github pages as we don't have something like nginx where we can write this.

This look like the best bet. I'm just testing it now
Screenshot 2025-01-17 at 10 56 55

@KrishnaIyer
Copy link
Contributor Author

Looks great, much prefer the new structure but we need to create 301 redirects for every URL change so that all our search results to go to 404s.

This a pain to do with hugo and github pages as we don't have something like nginx where we can write this.

Hmm, I don't understand. We already use aliases and that's how we've always handled moving pages.

@mjamescompton
Copy link
Contributor

@KrishnaIyer Sorry looks like they are there just did not work the first time I ran make server

@mjamescompton
Copy link
Contributor

And this was the first one I checked doc/content/hardware/gateways/_index.md which alias must be automatic somehow

@@ -1,7 +1,8 @@
---
title: "Troubleshooting CLI"
description: ""
aliases: [/getting-started/cli/troubleshooting]
aliases:
[/getting-started/cli/troubleshooting, /concepts/features/cli/troubleshooting]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This alias is to the new file location not the old. It should be the-things-stack/interact/cli/troubleshooting/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants