Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Kubernets docs #1220

Merged
merged 24 commits into from
Dec 27, 2023
Merged

Azure Kubernets docs #1220

merged 24 commits into from
Dec 27, 2023

Conversation

happyRip
Copy link
Member

@happyRip happyRip commented Nov 24, 2023

Summary

Ref https://github.com/TheThingsIndustries/product-management/issues/8

Screenshots

localhost_1313_the-things-stack_host_kubernetes_azure_(Laptop with HiDPI screen)

Changes

  • Split kubernetes section into azure and self-managed
  • Add Azure Kubernetes docs

Notes for Reviewers

nil

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@happyRip happyRip added this to the Nov 2023 milestone Nov 24, 2023
@happyRip happyRip self-assigned this Nov 24, 2023
@KrishnaIyer KrishnaIyer modified the milestones: Nov 2023, Dec 2023 Dec 5, 2023
Copy link
Contributor

@nejraselimovic nejraselimovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply fixes (for example for TTS shortcode, title sizes, example values in code blocks) to all occurrences in all files

Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.

Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements. Almost there!

Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good now. Please fix the small items that have comments on them.

@happyRip happyRip requested a review from KrishnaIyer December 22, 2023 16:25
@happyRip happyRip merged commit 5cdd0ff into master Dec 27, 2023
1 check passed
@happyRip happyRip deleted the feature/azure-k8s branch December 27, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants