Fix: Improve faction icons to show accurate icons in score screen #666

[L3-M]

• Reference topic: Menu improvements master topic #686

• Closes: Adding custom icons for all non-original armies #2581

[DevGeniusCode]

Can you elaborate a bit on the work and a screenshot of the textures?

[xezon]

Nice. Thank you. How does this look in game?

Please add feature comments in INI and a yaml file as described here:
https://github.com/TheSuperHackers/GeneralsGamePatch/blob/main/CONTRIBUTE.md#how-to-contribute-as-developer

[L3-M]

[xezon]

Nice it works. The images itself look a bit bad. Perhaps we can improve them? I think there are such faction logos also somewhere in retail UI textures... not 100% sure.

[L3-M]

i found those in SCShellUserInterface512_001 & SCShellUserInterface512_006. if there is a better quality logo. surely!

Ex:

[xezon]

Are these the textures that sit on the entrances of the Command Centers?

[L3-M]

I think so

Actually I found that Command Centers use this textures from TexturesZH.big

[tintinhamans]

These ones from the Command Centers look much better! Do we know where the other ones are used, maybe they should be updated with these.

[xezon]

Actually I found that Command Centers use this textures from TexturesZH.big

Yes. These should allow to create higher quality icons.

[L3-M]

Actually I found that Command Centers use this textures from TexturesZH.big

Yes. These should allow to create higher quality icons.

[xezon]

Nice. This is going into right direction.

There are some artifacts:

• icons have thin outline artifacts
• 2 icons have white color inside
• bottom left edge has bright pixel
• toxin symbol has boxy background on button and looks more blurry than others
• positioning and sizing can be optimized

How was the background created? With Vector Rectangle + Bevel Emboss + Gradient?

[xezon]

Btw, I have not checked PSD file, but it looks very large (4MB+). I suspect it has Smart Objects inside? If so, please flatten them after the sizing is nailed. Smart Objects make PSD very large and we always avoid them for this reason.

[xezon]

And another thought: Texture dimensions need to be reviewed with 4:3 resolution, because all ui was specifically created for this resolution (800 x 600). So if logo's looks squashed in 4:3, then it is not right.

[L3-M]

How was the background created? With Vector Rectangle + Bevel Emboss + Gradient?

Yes.

Btw, I have not checked PSD file, but it looks very large (4MB+). I suspect it has Smart Objects inside? If so, please flatten them after the sizing is nailed. Smart Objects make PSD very large and we always avoid them for this reason.

Yeah, I will lower the size in a commit after we agree on the texture.

And another thought: Texture dimensions need to be reviewed with 4:3 resolution, because all ui was specifically created for this resolution (800 x 600). So if logo's looks squashed in 4:3, then it is not right.

This is a 800x600 preview, logos seems fine.

[xezon]

Overall looks pleasing to the eye. It does seem to be a bit stretched wide, no? The toxin, stealth, nuke logo can be centered better. The airforce plane is a bit too tall. The tank logo is perhaps a bit too wide

[Chikinsupu]

I agree with xezon, the padding of the icons is inconsistent, other than that it looks nice so far

[L3-M]

Overall looks pleasing to the eye. It does seem to be a bit stretched wide, no? The toxin, stealth, nuke logo can be centered better. The airforce plane is a bit too tall. The tank logo is perhaps a bit too wide

I agree with you, for me it was ok. I fixed everything, redid the positioning and sizing.
Here is the latest version:

• Texture:

• Ingame:

[xezon]

It looks still a bit squashed in 4:3 but perhaps its ok so that it looks not as stretched in 16:9? A compromise?

[xezon]

Can you check if Right and Bottom values are correct? On the ingame image it looks not correctly cut out.

[L3-M]

I just checked, and all coords values are correct.

[xezon]

Hmm that is strange. It looks as if it is off by 1 pixel or so. The edge right and bottom looks different.

[xezon]

You can use @feature

[xezon]

This looks like it should not be here.

[L3-M]

Where should it be?

[xezon]

I think just remove it.

Also it looks like it is not just score screen, but also for Observer player info.

[xezon]

In alphabetical order, lowercase.

- art
- gui
- minor
- v1.0

[xezon]

How does it look with vanilla factions in the mix?

[L3-M]

[L3-M]

I think it's best to use black textures for the vanilla faction too so they have a same appearance or is it ok. What do you think?

[xezon]

Hmm the old ones do not mix well with the new ones. The original icons fill more space of the button. And they are not as crisp. I think it makes sense to create 12 buttons with same visual style.

In Control Bar Pro we have a texture that has 3 new buttons for vanilla factions. Perhaps you can reuse something of that. I think it is in the observer texture.

This:
https://github.com/TheSuperHackers/GeneralsControlBar/blob/main/ControlBarProZH/GameFilesEdited/Art/Textures/ControlButtonsPro_512_512.psd

[L3-M]

I retextured them with black.