Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian localization fixes and improvements #2544

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Nov 6, 2024

Russian localization fixes and improvements

Authored by dmgreeny

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related labels Nov 6, 2024
MAO to GLA change
Copy link
Collaborator Author

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is so large in this change that github does not allow to place inline comments.

TOOLTIP:BattleHonorEndurance

Why is TOOLTIP:BattleHonorEndurance suddenly so much longer?

TOOLTIP:Campaign1, TOOLTIP:Campaign2, TOOLTIP:Campaign3

What was wrong with the previous strings?

I see that TOOLTIP:Campaign1 shows Campaign 3 for some languages. That could be a separate change.

TOOLTIP:Shadows

-RU: "Включение\\выключение теней в игре. Они могут замедлить игру"
+RU: "Вкл.\откл. отображения теней в игре. Отключите для улучшения производительности"

Did you test that shows correctly in game? Perhaps \\ is escaped character. Perhaps use / instead. Same with TOOLTIP:BehindBuilding, TOOLTIP:UseStats, TOOLTIP:HeatEffects, TOOLTIP:WeatherEffects, GUI:Retaliation.
TOOLTIP:ShowProps uses /.

TOOLTIP:Shadows3D

Why is TOOLTIP:Shadows3D so much longer? Does it explain anything about crashes? Also see GUI:Shadows3D.

TOOLTIP:HeatEffects

Why is TOOLTIP:HeatEffects so much longer? Does it explain anything about bugs? Also see GUI:HeatEffects.

HELP:LeafletDrop-01, HELP:BunkerBuster-02, HELP:SupplyLines-01, ELP:SatelliteHack2-01, ...

looks long without line break.
You can find long strings with Python script Patch104pZH\Design\Scripts\str\find_long_strings.py. It writes to generated\long_strings.txt

HELP:SneakAttack-01

has space after \n

CREDITS:CameoPhotoshootStudio

perhaps meant to say "Photos shot at our West Studio" ?

###MAP:MD-USA06Warning17

+RU: "ВНИМАНИЕ:\nДоктор Тракс любит использовать Внезапную атаку\n, чтобы застать своего врага врасплох"

It is odd to place line break before comma.

@dmgreeny
Copy link
Collaborator

TOOLTIP:BattleHonorEndurance

Because the original Russian translation was incomplete and didn't provide any details on how to obtain this medal:
Original - RU: "Медаль за выносливость\nИгрок одержал победу на всех картах"
Edited - RU: "Медаль за выносливость\nИгрок одержал победу на всех картах и в зависимости от сложности получил Бронзовую, Серебряную или Золотую медаль"

In all other languages, you can see the name of medals but in old Russian lines this description was absent.
Example - US: "Endurance Honor\nBeat every map to earn a Bronze, Silver, or Gold medal"

@dmgreeny
Copy link
Collaborator

TOOLTIP:Campaign1, TOOLTIP:Campaign2, TOOLTIP:Campaign3

You commented on this change in EN localization, and I reverted it back. I will also revert this change here.
I will also submit a separate change for it later

@dmgreeny
Copy link
Collaborator

dmgreeny commented Feb 28, 2025

TOOLTIP:Shadows

As you can see on my screenshot, it shows up correctly and doesn't cause any issues.
Fixed
Untitled

@dmgreeny
Copy link
Collaborator

TOOLTIP:Shadows3D

Fixed

@dmgreeny
Copy link
Collaborator

TOOLTIP:HeatEffects

Fixed

@dmgreeny
Copy link
Collaborator

HELP:SneakAttack-01

Fixed

@dmgreeny
Copy link
Collaborator

CREDITS:CameoPhotoshootStudio

Fixed

@dmgreeny
Copy link
Collaborator

###MAP:MD-USA06Warning17

Fixed

@dmgreeny
Copy link
Collaborator

dmgreeny commented Feb 28, 2025

HELP:LeafletDrop-01, HELP:BunkerBuster-02, HELP:SupplyLines-01, ELP:SatelliteHack2-01, ...

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants