Skip to content

Commit

Permalink
Merge pull request #125 from TheRoddyWMS/FixForDirectCommand
Browse files Browse the repository at this point in the history
Fix for direct command
  • Loading branch information
dankwart-de authored Jul 18, 2018
2 parents 696d1fe + fdb43ce commit 27f8a28
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 13 deletions.
12 changes: 6 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/*
* Copyright (c) 2017 eilslabs.
* Copyright (c) 2017 German Cancer Research Center (DKFZ).
*
* Distributed under the MIT License (license terms are at https://www.github.com/eilslabs/Roddy/LICENSE.txt).
* Distributed under the MIT License (license terms are at https://www.github.com/theroddywms/Roddy/LICENSE.txt).
*/

plugins {
Expand All @@ -13,7 +13,7 @@ apply plugin: 'idea'
apply plugin: 'application'
apply plugin: 'maven'

group = "com.github.eilslabs"
group = "com.github.theroddywms"

mainClassName = 'de.dkfz.roddy.BEIntegrationTestStarter'
sourceCompatibility = '1.8'
Expand Down Expand Up @@ -59,8 +59,8 @@ dependencies {
compile group: 'commons-cli', name: 'commons-cli', version: '1.2'
compile group: 'org.apache.commons', name: 'commons-text', version: '1.1'
compile 'com.google.guava:guava:23.0'
// compile 'com.github.eilslabs:RoddyToolLib:develop-SNAPSHOT'
compile 'com.github.theroddywms:RoddyToolLib:0.0.4'
// compile 'com.github.eilslabs:RoddyToolLib:master-SNAPSHOT'
compile 'com.github.theroddywms:RoddyToolLib:1.0.0'
}

task writePom {
Expand Down Expand Up @@ -119,5 +119,5 @@ task uberjar(type: Jar, dependsOn:[':compileJava',':compileGroovy']) {

// Fix Gradle version
task wrapper(type: Wrapper) {
gradleVersion = '4.2.1'
gradleVersion = '4.8'
}
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.2.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-4.8-bin.zip
Original file line number Diff line number Diff line change
Expand Up @@ -307,11 +307,7 @@ abstract class BatchEuphoriaJobManager<C extends Command> {
BEJobResult jobResult
if (res.successful) {
String exID
try {
exID = parseJobID(res.resultLines.join("\n"))
} catch (BEException ex) {
throw new BEException("Full input was: '${res.resultLines.join("\n")}", ex)
}
exID = parseJobID(res.resultLines.join("\n"))
def job = command.getJob()
BEJobID jobID = new BEJobID(exID)
command.setJobID(jobID)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class DirectCommand extends Command {

//TODO Command assembly should be part of the file system provider? Maybe there is a need for a local file system provider?
//This is very linux specific...
commandString << parameterBuilder.toString() << StringConstants.WHITESPACE << command << " &> ${job.jobLog.getOut(job.jobCreationCounter.toString())} & wait &> /dev/null";
commandString << parameterBuilder.toString() << StringConstants.WHITESPACE << command << " &> ${job.jobLog.getOut(job.jobCreationCounter.toString())}";

return commandString.toString()
}
Expand Down

0 comments on commit 27f8a28

Please sign in to comment.