Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Remove All Whitespace in JavaScript #4268

Merged

Conversation

Kaamkiya
Copy link
Contributor

I Am Adding a New Code Snippet in an Existing Language

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Kaamkiya Kaamkiya marked this pull request as draft January 12, 2025 20:14
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why replaceAll isn't working is that we are using a very old version of node. I think if you edit testinfo.yml and change the version from 11-alpine to 20-alpine you may have better results. Also /\s/g is the correct regex to use

@Kaamkiya
Copy link
Contributor Author

It seems like upgrading the container broke some other programs, and I'm not sure if remove-all-whitespace works because I don't think it even got to that test.

@rzuckerm
Copy link
Collaborator

@Kaamkiya , If upgrading to node 20 is breaking existing tests, just go back to 11-alpine. I'll log an issue about the node version.

@Kaamkiya Kaamkiya marked this pull request as ready for review January 12, 2025 20:37
@Kaamkiya
Copy link
Contributor Author

Okay, I've downgraded the node image version and updated my code to match that version.

@rzuckerm
Copy link
Collaborator

@Kaamkiya I added this issue #4270 .

Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @Kaamkiya . Thanks for trying out node 20. Sorry that it didn't work out.

@rzuckerm rzuckerm merged commit 3f3bf54 into TheRenegadeCoder:main Jan 12, 2025
7 checks passed
@Kaamkiya Kaamkiya deleted the javascript-remove-all-whitespace branch January 12, 2025 20:39
@rzuckerm rzuckerm added enhancement Any code that improves the repo remove all whitespace See: https://sampleprograms.io/projects/remove-all-whitespace/ labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any code that improves the repo remove all whitespace See: https://sampleprograms.io/projects/remove-all-whitespace/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Remove All Whitespace in Javascript
2 participants