-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Template Additions and Modifications to Repo #4093
Open
TiaMarieG
wants to merge
18
commits into
TheRenegadeCoder:main
Choose a base branch
from
TiaMarieG:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
661767d
Selected a new problem as the one I chose got assigned to someone else
TiaMarieG d90dae4
First attempt - Wrote code based off experience with JS
TiaMarieG 5233d96
New attempt - passed 2/5 tests
TiaMarieG ff806f9
Updated code - 4/5 tests passed
TiaMarieG 9df665f
Final adjustment - 5/5 tests passed
TiaMarieG 042af5b
Merge branch 'main' into main
TiaMarieG 2ab0bc6
Removed node_modules and JSON files
TiaMarieG 27d3eb3
Created new template for repo contributions. Added node_modules/ to .…
TiaMarieG fd631d8
Merge branch 'main' into main
TiaMarieG 13cc7d7
Removed redundant line from .gitignore
TiaMarieG 6c4a2c6
Merge branch 'main' of https://github.com/TiaMarieG/sample-programs
TiaMarieG d7c4925
Moved location of ISSUE_TEMPLATE. Reworded additions to PULL_REQUEST …
TiaMarieG b93a70c
Renamed ISSUE_TEMPLATE to contribute-to-repo
TiaMarieG 7c14c7f
Merge branch 'main' into main
TiaMarieG 1ea0631
Added YAML to the top. Checking to see if it is visible now
TiaMarieG 7223fc9
Merge branch 'main' into main
TiaMarieG 8d7d80a
Added requested adjustments and altered form to more closely resemble…
TiaMarieG 752b6a6
Merge branch 'main' of https://github.com/TiaMarieG/sample-programs
TiaMarieG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
Congrats on taking the first step to contributing to the Sample Programs repository maintained by [The Renegade Coder][renegade-coder]! | ||
For simplicity, please make sure that your pull request includes one and only one contribution. | ||
|
||
Please fill _one_ of the sections below as applicable. | ||
Please also add any other relevant information to the Notes section at the bottom. | ||
You may delete or just ignore any other sections. | ||
For more information please refer to our [contributing documentation][contributing] | ||
|
||
## There is a broken link I want to report | ||
|
||
- [ ] I fixed #your-issue-number-here | ||
- [ ] I named the pull request using `Fixed {BROKEN LINK} in {DOCUMENTATION NAME}` format | ||
|
||
|
||
## I want to contribute to the repo in another way | ||
|
||
- [ ] I fixed #your-issue-number-here | ||
- [ ] I ensured that there are no typos and contribution is grammatically correct | ||
- [ ] I named the pull request using `Add {CONTRIBUTION} to {DOCUMENTATION NAME}` format | ||
|
||
## Other Notes | ||
|
||
Add notes here... | ||
|
||
|
||
|
||
[renegade-coder]: https://therenegadecoder.com/ | ||
[contributing-plagiarism]: https://github.com/TheRenegadeCoder/sample-programs/blob/master/.github/CONTRIBUTING.md#plagiarism | ||
[contributing-new-project]: https://github.com/TheRenegadeCoder/sample-programs/blob/master/.github/CONTRIBUTING.md#requirements-for-a-new-project | ||
[contributing-new-language]: https://github.com/TheRenegadeCoder/sample-programs/blob/master/.github/CONTRIBUTING.md#requirements-for-a-new-language | ||
[contributing-readme]: https://github.com/TheRenegadeCoder/sample-programs/blob/master/.github/CONTRIBUTING.md#create-readmes | ||
[contributing-tests-in-detail]: https://github.com/TheRenegadeCoder/sample-programs/blob/master/.github/CONTRIBUTING.md#tests-in-detail | ||
[contributing]: ../CONTRIBUTING.md | ||
[sample-programs-project-list]: https://sampleprograms.io/projects/ | ||
[contributing-modifications]: https://github.com/TheRenegadeCoder/sample-programs/blob/master/.github/CONTRIBUTING.md#modifying-existing-code-snippets |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,12 +9,14 @@ For more information please refer to our [contributing documentation][contributi | |
## I Am Adding a New Code Snippet in an Existing Language | ||
|
||
- [ ] I fixed #your-issue-number-here | ||
- [ ] I removed imported frameworks/libraries/packages or added them to .gitignore | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would probably write this as “I did not include any extra folders or libraries” or something similar. I think remove might confuse some folks into thinking they need to remove something. |
||
- [ ] I named the pull request using `Add {PROJECT} in {LANGUAGE}` format | ||
|
||
|
||
## I Am Adding a New Code Snippet in a New Language | ||
|
||
- [ ] I fixed #your-issue-number-here | ||
- [ ] I removed imported frameworks/libraries/packages or added them to .gitignore | ||
- [ ] I named the pull request using `Add {PROJECT} in {LANGUAGE}` format | ||
- [ ] I added a `testinfo.yml` files (see [contributing documentation][contributing-new-language]) | ||
- [ ] I used an officially supported docker image or one that I personally trust | ||
|
@@ -23,6 +25,7 @@ For more information please refer to our [contributing documentation][contributi | |
## I Am Adding New Tests for a Project | ||
|
||
- [ ] I fixed #your-issue-number-here | ||
- [ ] I removed imported frameworks/libraries/packages or added them to .gitignore | ||
- [ ] I named the pull request using `Add {PROJECT} Tests` format | ||
- [ ] I verified the project exists on the [Sample Programs Project List][sample-programs-project-list] | ||
- [ ] I added tests for every test case in the Testing table of the project description for the given project. (See [contributing documentation][contributing-tests-in-detail]) | ||
|
@@ -31,6 +34,7 @@ For more information please refer to our [contributing documentation][contributi | |
## I Am Adding New Tests for a Language | ||
|
||
- [ ] I fixed #your-issue-number-here | ||
- [ ] I removed imported frameworks/libraries/packages or added them to .gitignore | ||
- [ ] I named the pull request using `Add {LANGUAGE} Tests` format | ||
- [ ] I added a `testinfo.yml` files (see [contributing documentation][contributing-new-language]) | ||
- [ ] I used an officially supported docker image or one that I personally trust | ||
|
@@ -40,6 +44,7 @@ For more information please refer to our [contributing documentation][contributi | |
## I Am Modifying an Existing Code Snippet or Existing Tests | ||
|
||
- [ ] I fixed #your-issue-number-here | ||
- [ ] I removed imported frameworks/libraries/packages or added them to .gitignore | ||
- [ ] I have read about modifying existing code snippets or tests in the [contributing documentation][contributing-modifications] | ||
- [ ] I have explained why this modification is _necessary_ either in the issue linked above or in the notes below | ||
- [ ] I named the pull request using `Modify {PROJECT} {tests} in {LANGUAGE}` format | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
|
||
node_modules/ | ||
.idea/ | ||
*.class | ||
*.java~ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This more closely mirrors our existing pull request template, in which case I think it’s fine to move the additional headings into that template. If this is meant to be the new issue template, I think it needs to go into the ISSUE_TEMPLATES folder.