Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Platform Support Implementation #2

Closed
wants to merge 1 commit into from
Closed

Cross-Platform Support Implementation #2

wants to merge 1 commit into from

Conversation

nishbarot
Copy link
Collaborator

  1. Resource Management:

    • Added platform-specific checks using platform.system()
    • Implemented macOS resource limits using resource module
    • Maintained Windows support using win32job
    • Added graceful fallbacks for both platforms
  2. Dependencies:

    • Updated requirements.txt with conditional dependencies:
      psutil>=5.8.0
      pywin32>=228; platform_system == "Windows"
      
  3. Git Configuration:

    • Updated .gitignore to exclude platform-specific build artifacts
    • Added virtual environment directories to prevent large file commits
  • Windows: Uses win32job for process and memory management
  • macOS: Uses native resource module and process groups
  • Common: Uses psutil for cross-platform monitoring
  1. Testing Done
  • Tested on macOS Sonoma
  • [] Tested on Windows 10/11
  • Verified resource limits work on MacOS
  • Confirmed graceful fallbacks when limits can't be set
  1. Breaking Changes
    None. All changes are backward compatible.

Setup Instructions
After pulling these changes:

  1. Update your virtual environment:

@nishbarot nishbarot requested a review from NIGHTST4RS January 8, 2025 00:07
@NIGHTST4RS
Copy link
Member

Change accepted but will be separated to simplify development and eliminate the cross over to ensure better performance per platform

@NIGHTST4RS NIGHTST4RS closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants