Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update eLabFTW example #94

Closed
wants to merge 23 commits into from
Closed

update eLabFTW example #94

wants to merge 23 commits into from

Conversation

NicolasCARPi
Copy link
Contributor

  • flatten the json-ld
  • add missing mandatory properties for ./ node -> now valid ro-crate

* flatten the json-ld
* add missing mandatory properties for ./ node -> now valid ro-crate
@nicobrandt
Copy link
Collaborator

There are a bunch of variableMeasured with value null, I think they should be removed. The elabftw_metadata in variableMeasured is also missing a @type. Seems good to me otherwise.

@SteffenBrinckmann
Copy link
Collaborator

SteffenBrinckmann commented Nov 18, 2024

When I open it with the rocrate lib that @salexan2001 mentioned, I get an error:
ValueError: no @id in {'propertyID': 'elabftw_metadata', 'description': 'eLabFTW metadata JSON as string', 'value': '{"extra_fields": {"Raw data URL": {"type": "url", "value": "https://datalake.example.com/experiments/3921"}, "Annie, are you okay": {"type": "checkbox", "value": "", "description": "This is a checkbox custom input"}, "This is a custom list input": {"type": "select", "value": "Some choice", "options": ["Some choice", "Another choice", "A third choice"], "description": "The value is selected from a pre-defined list"}}}'}

Which are to my-understanding are not flattened.

@NicolasCARPi
Copy link
Contributor Author

NicolasCARPi commented Nov 26, 2024

Thank you for your feedback, I'll address your points in the next commit.

@NicolasCARPi NicolasCARPi self-assigned this Nov 26, 2024
@NicolasCARPi
Copy link
Contributor Author

I messed up with git, I'll open a new PR.

@NicolasCARPi NicolasCARPi deleted the elab2024-11 branch January 23, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants