Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some of TerrainLogic #897

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Apr 16, 2023

No description provided.

@jonwil jonwil requested a review from xezon April 16, 2023 05:12
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04 ⚠️

Comparison is base (95e08f8) 3.11% compared to head (efd557c) 3.08%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #897      +/-   ##
==========================================
- Coverage     3.11%   3.08%   -0.04%     
==========================================
  Files          791     794       +3     
  Lines        76679   77523     +844     
  Branches     12899   13086     +187     
==========================================
+ Hits          2389    2390       +1     
- Misses       73946   74790     +844     
+ Partials       344     343       -1     
Impacted Files Coverage Δ
src/game/client/terrainroads.h 0.00% <0.00%> (ø)
src/game/common/mapobject.cpp 0.00% <0.00%> (ø)
src/game/common/mapobject.h 0.00% <ø> (ø)
src/game/common/staticnamekey.cpp 0.00% <ø> (ø)
src/game/common/staticnamekey.h 50.00% <ø> (ø)
src/game/common/system/geometry.h 0.00% <ø> (ø)
src/game/logic/ai/aipathfind.cpp 0.00% <0.00%> (ø)
src/game/logic/ai/aipathfind.h 0.00% <0.00%> (ø)
src/game/logic/map/terrainlogic.cpp 0.00% <0.00%> (ø)
src/game/logic/map/terrainlogic.h 3.84% <0.00%> (+3.84%) ⬆️
... and 6 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jonwil jonwil force-pushed the terrainlogic branch 2 times, most recently from f463858 to efd557c Compare April 16, 2023 05:56
src/game/client/terrainroads.h Show resolved Hide resolved
src/game/common/system/geometry.h Show resolved Hide resolved
src/game/logic/map/terrainlogic.h Show resolved Hide resolved
src/game/logic/map/terrainlogic.h Show resolved Hide resolved
src/game/logic/map/terrainlogic.cpp Show resolved Hide resolved
src/game/logic/map/terrainlogic.cpp Show resolved Hide resolved
src/game/logic/map/terrainlogic.cpp Show resolved Hide resolved
src/game/logic/map/terrainlogic.cpp Outdated Show resolved Hide resolved
src/game/logic/map/terrainlogic.cpp Outdated Show resolved Hide resolved
src/game/logic/map/terrainlogic.cpp Show resolved Hide resolved
@jonwil jonwil requested a review from xezon April 17, 2023 13:36
@xezon
Copy link
Contributor

xezon commented Apr 17, 2023

Driving on bridge does not work correctly. Unit is able to pass, but will always cross it in its entirety. It is not possible to send unit half way over bridge. The mouse cursor also incorrectly indicates that the bridge is not passable.

Tested on Sand Serpent (2)

shot_20230417_230543_1

@xezon
Copy link
Contributor

xezon commented Apr 17, 2023

AI troops no longer capture civilian structures. Tested on Heartland Shield (2)

shot_20230417_232320_2

@jonwil
Copy link
Contributor Author

jonwil commented Apr 17, 2023

Bridge is fixed.
Tested with previous revision, AI doesn't capture oil derricks. Possibly related to #825 or #882

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shell map looks as usual.
Bridges work as original.
Terrain looks and acts normal.

@jonwil jonwil merged commit a0c1fbb into TheAssemblyArmada:develop Apr 18, 2023
@jonwil jonwil deleted the terrainlogic branch April 18, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants