Add Memory Allocator #12497
Add Memory Allocator #12497
Conversation
isidroas
force-pushed
the
malloc
branch
2 times, most recently
from
7a303ee to
94896dd
Compare
algorithms-keeper
bot
added
awaiting reviews
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| only add or remove elements at the end. | ||
| """ | ||
|
|
||
| def __init__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:
| def __init__(self): | ||
| self.data = bytearray() | ||
|
|
||
| def print(self, show_offset=False, bytes_per_row=4): |
There was a problem hiding this comment.
Please provide return type hint for the function: print. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: show_offset
Please provide type hint for the parameter: bytes_per_row
|
|
||
| return previous_program_break | ||
|
|
||
| def __len__(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: __len__. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file other/memory_allocator.py, please provide doctest for the function __len__
| # unallocated memory for other processes. | ||
| return len(self.data) | ||
|
|
||
| def __getitem__(self, index): |
There was a problem hiding this comment.
Please provide return type hint for the function: __getitem__. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file other/memory_allocator.py, please provide doctest for the function __getitem__
Please provide type hint for the parameter: index
| # fault' signal emitted by the OS | ||
| return self.data[index] | ||
|
|
||
| def __setitem__(self, index, value: int): |
There was a problem hiding this comment.
Please provide return type hint for the function: __setitem__. If the function does not return a value, please provide the type hint as: def function() -> None:
As there is no test file in this pull request nor any test function or class in the file other/memory_allocator.py, please provide doctest for the function __setitem__
Please provide type hint for the parameter: index
| 0 4 b'....' | ||
| """ | ||
|
|
||
| def realloc_block(self, block, new_size): |
There was a problem hiding this comment.
Please provide return type hint for the function: realloc_block. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: block
Please provide type hint for the parameter: new_size
| 0 1 b'.' | ||
| """ | ||
|
|
||
| def optimize_after_free(self, block): |
There was a problem hiding this comment.
Please provide return type hint for the function: optimize_after_free. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: block
| if block.is_last: | ||
| self.shrink_heap() | ||
|
|
||
| def shrink_heap(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: shrink_heap. If the function does not return a value, please provide the type hint as: def function() -> None:
| self.linked_list_remove_last() | ||
| self.heap.sbrk(-last.size) | ||
|
|
||
| def linked_list_remove_last(self): |
There was a problem hiding this comment.
Please provide return type hint for the function: linked_list_remove_last. If the function does not return a value, please provide the type hint as: def function() -> None:
| https://en.wikipedia.org/wiki/Fragmentation_(computing)#External_fragmentation | ||
| """ | ||
|
|
||
| def find_fit_block(self, size): |
There was a problem hiding this comment.
Please provide return type hint for the function: find_fit_block. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: size
Describe your change:
Checklist: