Grt: Jumper insertion improvement #6627
Conversation
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
…rtion functions Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
luis201420
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: luis201420 <[email protected]>
Signed-off-by: luis201420 <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@luis201420 CI have an error: |
Signed-off-by: luis201420 <[email protected]>
| mterm->getConstName(), | ||
| mterm->getMaster()->getConstName()); | ||
| return pin_name; | ||
| return true; |
There was a problem hiding this comment.
If the function always return true, why returning something at all? Should it be a void instead of bool?
| @@ -1062,8 +926,8 @@ void RepairAntennas::addJumperHorizontal(const int& seg_id, | |||
| route[seg_id].init_x = bridge_final_x; | |||
| } | |||
|
|
|||
| void RepairAntennas::addJumperVertical(const int& seg_id, | |||
| GRoute& route, | |||
| void RepairAntennas::addJumperVertical(GRoute& route, | |||
There was a problem hiding this comment.
The functions addJumperVertical and addJumperHorizontal looks almost like the same. Perhaps you could merge them into a single function that receives a bool to define if the jumper is vertical or horizontal, and then you can define the jumper coordinantes according to this boolean argument.
| mterm->getConstName(), | ||
| mterm->getMaster()->getConstName()); | ||
| return pin_name; | ||
| return true; | ||
| } | ||
|
|
||
| int RepairAntennas::getSegmentByLayer( |
There was a problem hiding this comment.
Maybe a better name would be getSegmentsPerLayer.
| void RepairAntennas::getSegmentsConnectedToPin( | ||
| const odb::dbITerm* iterm, | ||
| LayerToSegmentNodeVector& segment_by_layer, | ||
| SegmentNodeIds& seg_connected_to_pin) |
There was a problem hiding this comment.
I believe it would be easier to use the GlobalRouter::Pin here, instead of the odb::dbITerm. With GlobalRouter::Pin, you can simply use the getOnGridPosition function and use it to check what segments overlap with the pin or not.
| int pos_y = seg_init_y; | ||
| int last_block_x = pos_x; | ||
| int last_block_y = pos_y; | ||
| bool has_available_resources, is_via; |
There was a problem hiding this comment.
Avoid multiple declarations in a single line. Tho it saves line count, I find it quite easy to miss one of the declarations.
| getViaPosition(segment_graph, route, seg_node, via_pos); | ||
|
|
||
| // Save best positions to add jumper | ||
| std::vector<int> position_cand; |
There was a problem hiding this comment.
What does cand stand for?
|
clang-tidy review says "All clean, LGTM! 👍" |
New implementation of jumper insertion using DFS algorithm to find the GSegments that cause antenna violation for a pin.
The number of inserted jumpers increases because a jumper will be added to each GSegment connected to the pin with violation.
In the results obtained the number of diodes inserted in the post-GRT stage in most designs is reduced.