Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psm: add check for bterms option #6584

Merged
merged 6 commits into from
Jan 24, 2025
Merged

psm: add check for bterms option #6584

merged 6 commits into from
Jan 24, 2025

Conversation

gadfort
Copy link
Collaborator

@gadfort gadfort commented Jan 23, 2025

Adds:

  • flag to enforce bterms are present for a net during check_power_grid

@gadfort gadfort requested a review from maliberty January 23, 2025 21:07
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

maliberty
maliberty reviewed Jan 23, 2025
View reviewed changes
src/psm/README.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gadfort gadfort requested a review from maliberty January 24, 2025 17:48
@gadfort
Copy link
Collaborator Author

gadfort commented Jan 24, 2025 •
edited
Loading

@maliberty I switched the polarity of the flag so it will fail by default if bpins are not found.
I think this command is still commented out in ORFS, so until you reenable it, it will not present an issue (although I would argue that you should enable it since the CI issues should be resolved).

maliberty
maliberty reviewed Jan 24, 2025
View reviewed changes
src/psm/test/gcd_test_assign_power.tcl
@@ -10,5 +10,5 @@ set voltage_file [make_result_file gcd_test_vdd-voltage.rpt]
set_pdnsim_inst_power -inst _440_ -power 1e-5
set_pdnsim_inst_power -inst _829_ -power 1e-5

check_power_grid -net VDD
check_power_grid -net VDD -dont_require_terminals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we could generate the terminals rather than using the switch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pdngen can generate them if it's setup to do so, that is the correct place to do it, this is only a checker.

@maliberty maliberty merged commit abaead0 into The-OpenROAD-Project:master Jan 24, 2025
11 checks passed
@gadfort gadfort deleted the psm-check-bterms branch January 24, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadfort @maliberty