Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdn: no outside die shapes #6583

Merged
merged 4 commits into from
Jan 23, 2025
Merged

pdn: no outside die shapes #6583

merged 4 commits into from
Jan 23, 2025

Conversation

gadfort
Copy link
Collaborator

@gadfort gadfort commented Jan 23, 2025

Closes: #6445

Changes:

  • adds flag to permit pdn rings outside the die, changes the default to not allowing it
  • Updates tests that had rings outside the die boundaries.

@gadfort gadfort requested a review from maliberty January 23, 2025 19:07
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gadfort
pdn: fix python formatting
39f2724 
Signed-off-by: Peter Gadfort <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@maliberty
Copy link
Member

Please look at the failure. It might be you need to merge master to your branch.

@maliberty maliberty enabled auto-merge January 23, 2025 20:05
@gadfort
Copy link
Collaborator Author

gadfort commented Jan 23, 2025 •
edited
Loading

@maliberty I've seen 108 - odb.floorplan_initialize.tcl (Failed) fail several times are you sure there isn't some transient issue there?

@maliberty
Copy link
Member

I don't know but the fact that it passed in pr-merge makes me think it could just be an older failure.

@gadfort
Copy link
Collaborator Author

gadfort commented Jan 23, 2025

@maliberty looks like retriggering it makes it pass

@maliberty maliberty merged commit 287c3f4 into The-OpenROAD-Project:master Jan 23, 2025
11 checks passed
@gadfort gadfort deleted the pdn-no-outside-shapes branch January 23, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDN creates ring outside of die area
2 participants
@gadfort @maliberty