fix: fix #783 remote container construction sites not beeing handled #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea is to not build containers until the spawning structures are at or above RCL 3. I think this is preferable because excess energy in non-reserved remotes can go towards containers. That being said, i'm not super attached to that solution over this one |
|
Ah i see hmm didn't pay attention to that it's supposed to check it against the commune and not the remote room. |
|
Ohhh I didn't notice it was checking the remote instead of the commune 🤦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know what the history behind this is but the current check for available amout of storage in spawns + extensions doesn't make any sense for a remote. I've switched that to just check if the room is reserved. This works well for me.
fixes #783