Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complier compliance & BandAid fix for operator.ts #775

Merged

Conversation

realacesu
Copy link
Collaborator

Changed all constants/general imports to use relative importing to file importing it

Changed constants/general.ts and commented a non power task. if we take this approach ALL tasks must have all task function declarations in the role files. Going forward, add these and maybe error with not implemented and creep debug info to see what called it because it shouldn't be called. This is generally avoided because creeps individually select tasks and are not assigned. We will likely never see this.

@realacesu realacesu requested a review from CarsonBurke January 31, 2024 15:18
@realacesu
Copy link
Collaborator Author

oops added notmycreeps.invader, this addition doesn't break anything as it still passes invaders to enemy

@CarsonBurke
Copy link
Member

I like idea of notMyCreeps including invaders :)

@CarsonBurke
Copy link
Member

I'm experiencing zero issues with constants on the unstable branch without using this PR. What is the reason behind the relative imports?

I like the invader thing. Could you make a separate PR for that please? I will happily merge that ASAP

@realacesu
Copy link
Collaborator Author

I'm experiencing zero issues with constants on the unstable branch without using this PR. What is the reason behind the relative imports?

On node 16.20.2, and 20.10.0 This was occurring for me, with no changes to the unstable branch

@realacesu
Copy link
Collaborator Author

Adding relative imports took away the require that was present on the top of the file after the banner

@CarsonBurke
Copy link
Member

Adding relative imports took away the require that was present on the top of the file after the banner

Which file and which banner? sorry.

@CarsonBurke
Copy link
Member

I'm experiencing zero issues with constants on the unstable branch without using this PR. What is the reason behind the relative imports?

On node 16.20.2, and 20.10.0 This was occurring for me, with no changes to the unstable branch

v16.17.1, no issues for me

@realacesu
Copy link
Collaborator Author

realacesu commented Feb 2, 2024

Adding relative imports took away the require that was present on the top of the file after the banner

Which file and which banner? sorry.

Build output. Complied main.js output

Banner comes from rollup cfg

@realacesu
Copy link
Collaborator Author

Node v16.17.1 same issue without PR. Unsure why its doing this

@CarsonBurke CarsonBurke merged commit 277472c into The-International-Screeps-Bot:unstable Feb 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants