fix: bim-icon scg image position & bim-label font-size/line height #56. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the packages/core/src/components/Label the .parent had set the user-select property as none. This has now been switched to text and it works. Reviewed by: Goulielmos Floros Ref: ThatOpen#57
modified package.json files to include lit as peer and devdependencies. modified vite.config.js to prevent Lit from being included in my final build. Reviewed-by: Goulielmos Floros Ref: ThatOpen#25
…atOpen#56. For this one ThatOpen#56 I fixed the initial bug for the svg image by adding display: flex; in the style of packages\core\src\components\Icon.ts. I also fixed a related issue with regards to the bim-label size and line height with ref ThatOpen#55, by changing line-height from 1 rem to 1em, from packages\core\src\components\Label.ts style. We could also remove the property entirely and it would work. To test it you can go to the Label html file change the font-size and the text and see that the icon will always be on the same place and the line-height now adjusts to the size. Reviewed-by: Goulielmos Floros Ref: ThatOpen#56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For this one with ref #56 I fixed the initial bug for the svg image by adding display: flex; in the style of packages\core\src\components\Icon.ts.
I also fixed a related issue with regards to the bim-label size and line height with ref #55, by changing line-height from 1 rem to 1em, from packages\core\src\components\Label.ts style. We could also remove the property entirely and it would work.
To test it you can go to the Label html file change the font-size and the text and see that the icon will always be on the same place and the line-height now adjusts to the size.
Reviewed-by: Goulielmos Floros
Ref: #56
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).