Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bim-label font size and line heigth #55

Open
5 tasks done
YgorFasa98 opened this issue Nov 28, 2024 · 0 comments
Open
5 tasks done

bim-label font size and line heigth #55

YgorFasa98 opened this issue Nov 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@YgorFasa98
Copy link

Describe the bug 📝

When I change the font size in a bim-label component, the height of the row remains the same and it will not be updated to the new font size. I noticed that the problem could be in the line-height set to 1.1rem, probably it should be 1.1em so it will adapt on the font size of the parent element.

Situation with 1.1rem:
image

Situation with 1.1em:
image

Reproduction ▶️

No response

Steps to reproduce 🔢

Create a bim-label element and set the font size to 50px for example

System Info 💻

//

Used Package Manager 📦

npm

Error Trace/Logs 📃

No response

Validations ✅

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
  • Check that this is a concrete bug. For Q&A join our Community.
  • The provided reproduction is a minimal reproducible example of the bug.
@YgorFasa98 YgorFasa98 added the bug Something isn't working label Nov 28, 2024
@YgorFasa98 YgorFasa98 mentioned this issue Nov 28, 2024
Open
5 tasks
GoulielmosFloros added a commit to GoulielmosFloros/engine_ui-components that referenced this issue Mar 2, 2025
@GoulielmosFloros
fix: bim-icon scg image position & bim-label font-size/line height Th…
8f3d49e 
…atOpen#56.

For this one ThatOpen#56 I fixed the initial bug for the svg image by adding display: flex; in the style of packages\core\src\components\Icon.ts.

I also fixed a related issue with regards to the bim-label size and line height with ref ThatOpen#55, by changing line-height from 1 rem to 1em, from packages\core\src\components\Label.ts style. We could also remove the property entirely and it would work.

To test it you can go to the Label html file change the font-size and the text and see that the icon will always be on the same place and the line-height now adjusts to the size.

Reviewed-by: Goulielmos Floros
Ref: ThatOpen#56
@GoulielmosFloros GoulielmosFloros mentioned this issue Mar 2, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@YgorFasa98