feat(thread): implement sendReadReceipt api method
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/network-api/index.ts
Outdated
| }), | ||
| }) | ||
|
|
||
| return { |
There was a problem hiding this comment.
All responses from tumblr api is wrapped in a response object. Something like this
{
"meta": {
"status": 200,
"msg": "OK"
},
"response": {
"user": {
"name": "nurguly",
"likes": 32,
"following": 79,
...
}
}
}
So for each api request I "unwrap" it. Makes it much easier to deal with static typing and dealing with responses in general.
There was a problem hiding this comment.
Should be slightly more memory-efficient to just return response.json.response rather than spreading it, since this creates and returns a shallow copy of the object. Think that's what Kishan was getting at. You'd still be "unwrapping" it, but without the need for the extra mem.
There was a problem hiding this comment.
Ahhhh! I misunderstood. Updated now! 01d5aa1
batuhan
approved these changes
Mar 6, 2024
batuhan
force-pushed
the
nurguly/plt-1153-tumblr-implement-sendreadreceipt-api
branch
from
01d5aa1 to
ddb7dae
Compare
|
Install this branch's platform manifest to test its implementation. Manifest Installation (Texts Desktop)
|
dadish
force-pushed
the
nurguly/plt-1153-tumblr-implement-sendreadreceipt-api
branch
from
ddb7dae to
01d5aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the
sendReadReceiptapi method. Along with a "Stealth Mode" support for the Tumblr.Testing Instructions
platfomr-tumblrand build ityarn tsctumblrbotand message it. Likeshow me cat gif. Wait until it responds.tumblrbot. (Do not open tumblrbot conversation panel in tumblr.com or else it will mark the conversation as read.)tumblrbotthread.tumblrbotbecomes read within 10 seconds.