Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI update #7443

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

UI update #7443

wants to merge 40 commits into from

Conversation

ljowen
Copy link
Contributor

@ljowen ljowen commented Jan 13, 2025 •
edited
Loading

What this PR does

Major change to default theme and appearance:
May introduce breaking changes with existing maps so will be a major version.

Visual changes

  • Generally increase padding
  • Workbench now "floating" with variable height and semi transparent background
  • Change to darker colours in default theme to increase contrast
  • Font changed from "Nunito" to "Inter", generally increase font sizes
  • More rounded corners, generally decrease border radius to 8px for major panels and 4px for smaller components

Before
before
After
after

Functional changes

  • Bug fixed where tour would not work correctly if workbench was minimised
  • Add config option to keep catalog open when adding / removing datasets keepCatalogOpen
  • Remove dataset count shown on map
  • Hide chart at mobile viewports

Test me

Before: http://ci.terria.io/main
After: http://ci.terria.io/ui-update-fonts

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@CLAassistant
Copy link

CLAassistant commented Jan 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ljowen ljowen marked this pull request as draft January 16, 2025 01:32
@zoran995

This comment was marked as resolved.

Sign in to view
@zoran995 zoran995 mentioned this pull request Jan 21, 2025
Open
@ljowen
Copy link
Contributor Author

ljowen commented Jan 23, 2025 •
edited
Loading

Thanks for the review @zoran995 I've addressed most of these now except for 6), I'm in conversation with our designer about reverting to the small "Show workbench button" which would be my preference

@irbian
Copy link
Contributor

irbian commented Jan 23, 2025

Our client love the new changes! there is any ETA of them?

@ljowen ljowen changed the title WIP: UI update UI update Jan 28, 2025
@ljowen ljowen marked this pull request as ready for review January 28, 2025 00:40
pjonsson
pjonsson reviewed Jan 28, 2025
View reviewed changes
demo.patch Outdated Show resolved Hide resolved
pjonsson
pjonsson reviewed Jan 28, 2025
View reviewed changes
demo2.patch Outdated Show resolved Hide resolved
pjonsson
pjonsson reviewed Jan 28, 2025
View reviewed changes
lib/Models/Terria.ts Outdated Show resolved Hide resolved
pjonsson
pjonsson reviewed Jan 28, 2025
View reviewed changes
lib/Styled/Button.tsx Outdated Show resolved Hide resolved
@ljowen ljowen force-pushed the ui-update-fonts branch 2 times, most recently from b1c6ac3 to a0071e8 Compare January 30, 2025 05:07
ljowen and others added 16 commits February 13, 2025 09:37
@ljowen
Fix Feedback panel btn radius, restore fullscreen btn text
036c4cb
@ljowen
SidePanel -> full height until menu clipping issue can be resovled
9f7fcd6 
Diff tool: keep side panel open, position accordingly
remove patch files
@pjonsson @ljowen
Cherry-pick ESLint: return from onToggle functions
7f8dc2b 
- Remove use strict on .tsx files
- fix keepCatalogOpen type
@ljowen
Remove unused code, fix compass-inner-arrows icon
fe19300
@ljowen
Compass icon fix
532aa64
@ljowen
Remove align-items: center on branding (breaking NSW DT logos)
f212507
@ljowen
Fix imports
ef50ff2 
- run prettier
@ljowen
Allow time for workbench to close when starting tour
e90fca0
@ljowen
Add margin to timeline to account for "title"
5a4c207 
Fix location search result radius
Revert changes to BottomLeftBar: attributions will be shown again
@ljowen
Add min-height to story builder items container so dropdown works
293e60c
@ljowen
Decouple badgeBar from StoryBuilder
f869b5e
@ljowen
Make explorer window radii consistent
cc65655 
Update workbench comment
Fix menu bar left margin when workbench closed
Adjust toast position
@ljowen
Add outline to map controls, fix N indicator on compass ring
09bd597
@ljowen
Fix tests: mock clock to wait for workbench animation
0829d20
@ljowen
Move clock mocks into beforeEach in case test errors
7efa168
@ljowen
post rebase webpack5 fixes
8490771
@ljowen
Adjust navigation and map control positions
47ebc4c 
Change trainer bar background color
@ljowen ljowen force-pushed the ui-update-fonts branch 3 times, most recently from c39d684 to 8c0126b Compare February 13, 2025 05:54
@ljowen
Fix story item text overflow
d0aee46 
- adjust story panel width
- reduce max height on story body -> 200px, remove padding when collapsed
- prettier
- lint fixes in workbench
@ljowen ljowen requested a review from zoran995 February 17, 2025 02:46
@ljowen ljowen dismissed zoran995’s stale review February 17, 2025 02:46

Fixed story builder scrolling

@na9da na9da self-assigned this Feb 17, 2025
@ljowen
Copy link
Contributor Author

ljowen commented Feb 17, 2025

Our client love the new changes! there is any ETA of them?

Hi @irbian , we aim to get these changes released by the end of this month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjonsson pjonsson pjonsson left review comments

@zoran995 zoran995 Awaiting requested review from zoran995

At least 1 approving review is required to merge this pull request.

Assignees

@na9da na9da

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ljowen @CLAassistant @zoran995 @irbian @AmberStandley83 @pjonsson @na9da