Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port WPS group from master to v8 #5309

Merged
merged 11 commits into from
Mar 17, 2021
Merged

Port WPS group from master to v8 #5309

merged 11 commits into from
Mar 17, 2021

Conversation

na9da
Copy link
Collaborator

@na9da na9da commented Mar 9, 2021

What this PR does

Fixes #5150

Ports WPS group from master to v8

Also fixes the problem reported in TerriaJS/RaPPMap#105 where a + icon is shown instead of a bar chart icon for catalog functions in the explorer.

Testing

  1. Visit CI instance
  2. Expand the Wave energy group from catalog
  3. You should be able to see the processes created as new members under the catalog group
  4. The info section should show the details of the service

### TODO before merge
Remove unrelated temporary fix to make CI pass

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated CHANGES.md with what I changed.

@nf-s nf-s self-assigned this Mar 10, 2021
Copy link
Contributor

@nf-s nf-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly!

Optional extra - it would be great if you add WPS Group to "Add Remote Data" section

https://github.com/TerriaJS/terriajs/blob/d713ab52d0b9faf71f791a3a9c321eaf0fbfa807/lib/Core/getDataType.js

@na9da na9da merged commit f5e7de4 into next Mar 17, 2021
@na9da na9da deleted the wps-group branch March 17, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants