-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common tags to basalt blocks #117
Conversation
I guess the one thing that makes this tricky is that in 1.16 we renamed basalt to Volcanic Rock to not conflict with vanilla's basalt. Not sure what exactly we should do here |
Hmm you're right, people will not get the connection that your volcanic rock grinds into basalt dust. At the same time vanilla is soon going to have more basalt than anyone can carry, with the caveat that it's only available via the nether. |
I think it would will be reasonable to treat volcanic rock like basalt even after the name change. |
It might still make sense to have Volcanic Rock grind into Basalt Dust still. |
Uh, please disregard the above mess. I think this change makes sense, but it should probably be targeted on 1.16 |
@Sturmlilie would you mind updating this PR to 1.16, if not I'll go ahead and close the PR |
For compatibility with TechReborn.
Tested with latest Tech Reborn for 1.16.1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good change. Perhaps we could have a separate terrestria:volcanic_rock
tag and then include that tag in the c:basalt
tag, but that's not strictly needed.
Just a heads up, there are problems with tags on latest MC versions. See: TechReborn/RebornCore#159 |
@Sturmlilie is this just the in-dev issue? |
@NeusFear not sure what "in-dev" refers to; we've had multiple people hop on the TechReborn discord and report their Blockus compat being broken. It means that even if this PR gets merged, until the tag issue gets fixed, Terrestria basalt will presumably not be grindable in TR. |
in-dev means when launching the game from the development environment as opposed to using a built jar as a mod to the obfuscated game. |
I think it should be fine |
I pretty much never use this loom feature. |
For compatibility with TechReborn; see TechReborn/TechReborn#2091