Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly order metadata and cache free operations #86

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chrisdennis
Copy link
Member

No description provided.

Copy link
Contributor

@cljohnso cljohnso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a few excess items.

@@ -0,0 +1,113 @@
/*
* Copyright 2025 Terracotta, Inc., a Software AG company.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAG reference for a new file?

import com.terracottatech.frs.RestartStore;
import com.terracottatech.frs.RestartStoreException;
import com.terracottatech.frs.RestartStoreFactory;
import com.terracottatech.frs.config.FrsProperty;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few dead imports ...


}

protected static void destroyMap(Map<?, ?> map) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to call this?

@chrisdennis chrisdennis force-pushed the partial-cache-consistency branch from da79ef0 to 5609c18 Compare January 21, 2025 22:56
@chrisdennis chrisdennis force-pushed the partial-cache-consistency branch from 5609c18 to 448765a Compare January 22, 2025 14:48
@chrisdennis chrisdennis requested a review from cljohnso January 22, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants